Added limits useful for testing #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahsra
commented
Oct 18, 2023
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.io.TempDir; | ||
|
|
There was a problem hiding this comment.
We were missing good coverage of the caching JavaParser test. I know this is getting removed soon, but I created this test as part of debugging, so why not keep it in.
|
Nice work! ✅ I analyzed your pull request and don't see any hardening opportunities. |
dhafley
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to restrict the amount of work done in a codemodder scan. I wish I had these flags useful for testing several times before now, and I think eventually they may be useful for downstream consumers to "limit the work" that a codemodder run can do.
Hopefully, we'll be following this PR quickly with work to make these parameters obsolete (because removing
CompilationUnitcaching and I/O parallelization will fix everything), but I like having them around in case we ever run into situations where we'd like to performance test locally.