Sonarcloud codemod - Harden String Parse to primitives (Integer/Float constructor cases) #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
float myFloat = new Float(myNum);
int myInteger = new Integer(myNum);
nahsra
requested changes
Dec 2, 2023
core-codemods/src/test/resources/harden-string-parse-to-primitives-s2130/Test.java.after
Outdated
Show resolved
Hide resolved
plugins/codemodder-plugin-sonar/src/main/java/io/codemodder/providers/sonar/SonarModule.java
Show resolved
Hide resolved
core-codemods/src/test/resources/harden-string-parse-to-primitives-s2130/Test.java.before
Outdated
Show resolved
Hide resolved
core-codemods/src/main/java/io/codemodder/codemods/HardenStringParseToPrimitivesCodemod.java
Outdated
Show resolved
Hide resolved
core-codemods/src/main/java/io/codemodder/codemods/HardenStringParseToPrimitivesCodemod.java
Show resolved
Hide resolved
nahsra
approved these changes
Dec 2, 2023
…string-parsing-CONSTRUCTORS
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish Sonarcloud codemod (HardenStringParseToPrimitivesCodemod) to enforce the appropriate parsing technique for converting Strings to primitive types in the codebase.
This PR handles the
new Float//new Integerconstructor cases (ObjectCreationExpr nodes).Previous PR that handles
.valueOfcases -> #250Sonar rule reference https://rules.sonarsource.com/java/RSPEC-2130/
sonar cloud issues related to string-to-primitive conversion: https://sonarcloud.io/project/issues?fileUuids=AYvtrjqILCzGLicz7AY_&resolved=false&id=nahsra_WebGoat_10_23
IMPORTANT NOTE!!!!
As you can see on the Test.java.before the following cases are not reported by sonarcloud:
Therefore, those cases are not being fixed