Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip LLM codemods when no service is available #418

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

drdavella
Copy link
Member

No description provided.

@drdavella drdavella requested review from nahsra and gilday July 11, 2024 17:58
@drdavella drdavella force-pushed the skip-llm-codemods-gracefully branch from 47220e4 to 8991795 Compare July 11, 2024 18:49
import io.codemodder.RuleSarif;
import io.codemodder.SarifPluginRawFileChanger;
import java.util.Objects;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add a comment here when to use this type since it's public.

this.openAI = Objects.requireNonNull(openAI);
}

@Override
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add a comment here that I think subclassses shouldn't override this without also considering the same logic?

@drdavella drdavella requested a review from nahsra July 11, 2024 19:16
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@drdavella drdavella merged commit 02b25a8 into main Jul 11, 2024
6 checks passed
@drdavella drdavella deleted the skip-llm-codemods-gracefully branch July 11, 2024 19:37
drdavella added a commit that referenced this pull request Jul 11, 2024
This codemod does not inherit from the base class with the existing
check so it did not benefit from the work in #418.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants