Fixes issue where multiple mixed type injections were not fixed #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrecsilva
force-pushed
the
sql-snyk-fix
branch
from
e7032e3
to
ceb3e74
Compare
nahsra
requested changes
Aug 1, 2024
...odder-base/src/main/java/io/codemodder/remediation/sqlinjection/SQLInjectionFixComposer.java
Show resolved
Hide resolved
...odder-base/src/main/java/io/codemodder/remediation/sqlinjection/SQLInjectionFixComposer.java
Show resolved
Hide resolved
| return SQLTableInjectionFilterTransform.findAndFix(methodCallExpr); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
JavaDoc
Should this type be an interface and the others be implementations?
There was a problem hiding this comment.
A bit hesitant on that since these keep changing. Notice how the checkAndFix for SQLParameterization is slightly different (returns an Optional), but this difference is necessary for the compostion.
I guess we could have a generic find-and-fix-transform interface if you feel the remediators need a stronger contract.
|
nahsra
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.