Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use-walrus-if codemod can handle unused variables #477

Merged
merged 2 commits into from
Apr 16, 2024
Merged

use-walrus-if codemod can handle unused variables #477

merged 2 commits into from
Apr 16, 2024

Conversation

clavedeluna
Copy link
Contributor

Overview

use-walrus-if codemod should not use a walrus if variable is not used

Closes #264

andrecsilva
andrecsilva approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@andrecsilva andrecsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicks, looks ok otherwise.

src/core_codemods/use_walrus_if.py Outdated Show resolved Hide resolved
src/core_codemods/use_walrus_if.py Outdated Show resolved Hide resolved
src/core_codemods/use_walrus_if.py Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@clavedeluna clavedeluna added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit d44dc34 Apr 16, 2024
12 checks passed
@clavedeluna clavedeluna deleted the walrus-unused-var branch April 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrecsilva andrecsilva andrecsilva approved these changes

@drdavella drdavella Awaiting requested review from drdavella drdavella is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle unused assignments in use-walrus-if codemod
2 participants
@clavedeluna @andrecsilva