Fix up fmod_preload for newer glibc versions #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer glibcs don't have this. Note the string "GLIBC_2.17" is different for different architectures - but we only target ARM64 anyway.
|
Thank you for your contribution! The goal is to eventually get rid of fmod_preload and use Mono runtime configurations instead (see #7). I'll keep this open until that is implemented since merging it right now could potentially break Switch compatibility. |
|
I did test this on my Switch, it's just running 22.04 instead of 18.04. I am pretty sure it would be compatible - Mono runtime configs is a nice solution though, I wasn't aware you could map DLLs and symbols around like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The private
_dl_symfunction is missing from newer glibcs. Instead usedlvsym, a stable function meant for getting a specific versioned symbol. On ARM64,GLIBC_2.17is dlsym's version (other architectures would need different strings).Note that this also uses(Edit: the original code does this too, don't mind me)dlsymto get the address of..dlsym, which should play a bit nicer with anyone else who's hooking that. There's a few libraries I've seen around that do it so they can mess with OpenGL or whatever.Tested working on Ubuntu Jammy for Switch and Fedora 39 Asahi. NOT tested on 18.04, which is still pretty popular on Switch.