Add access-tls-socket-fd-via-syscall feature flag to cloud config manager
#1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ager Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
ddelnano
changed the title
access-tls-socket-fd-via-syscall feature flag to cloud config manager
aimichelle
approved these changes
Apr 6, 2023
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
May 1, 2023
…anager (pixie-io#1188) Summary: Add `access-tls-socket-fd-via-syscall` feature flag to cloud config manager This feature flag will be used to opt internal clusters into the new tls tracing implementation developed in pixie-io#1120. We may want a more sophisticated toggle for gradually opting in more clusters, but this will suffice for the initial set of testing (validating some hand picked clusters). Relevant Issues: pixie-io#692 Type of change: /kind feature Test Plan: Verified the following: - [x] Deploying a new pixie install without launch darkly credentials results in the default, `false`, value ([P354](https://phab.corp.pixielabs.ai/P354)) - [x] Deploying a new pixie install with a cloud with launch darkly credentials results in a `true` value ([P355](https://phab.corp.pixielabs.ai/P355)) Signed-off-by: Dom Del Nano <ddelnano@pixielabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add
access-tls-socket-fd-via-syscallfeature flag to cloud config managerThis feature flag will be used to opt internal clusters into the new tls tracing implementation developed in #1120. We may want a more sophisticated toggle for gradually opting in more clusters, but this will suffice for the initial set of testing (validating some hand picked clusters).
Relevant Issues: #692
Type of change: /kind feature
Test Plan: Verified the following:
false, value (P354)truevalue (P355)