Show the same sidebar everywhere #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure that i like always showing the admin pages on the sidebar when you're not in the admin view. I feel like many of those pages are less important and shouldn't be front-and-center all of the time. It wasn't perfect, but can we go back to the behavior we had before these refactors? |
Done. They no longer show in the live views but do still show in the admin views and in the data retention views. |
aimichelle
reviewed
Jul 17, 2023
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
…show them elsewhere Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>
NickLanam
force-pushed
the
shared-sidebar
branch
from
211c284
to
b7e0dbf
Compare
aimichelle
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Instead of showing and hiding parts depending on where you are.
We don't have a huge number of items in this bar, so it makes sense to always have all of them.
In the admin and data retention views, it will pick the default cluster for the script links.
Relevant Issues: N/A
Type of change: /kind bugfix
Test Plan: Load the live views, the admin pages, and the data retention view.
All of them should keep the same sidebar, and whichever view you're on should be highlighted.