fix: add logging for reporting errors. useful for debugging config-ma… #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caphrim007
had a problem deploying
to
pr-actions-approval
GitHub Actions
Error
caphrim007
force-pushed
the
fix/add-logging-for-errors
branch
from
5702a3f
to
7e784f6
Compare
caphrim007
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
caphrim007
force-pushed
the
fix/add-logging-for-errors
branch
from
7e784f6
to
8558727
Compare
caphrim007
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
caphrim007
force-pushed
the
fix/add-logging-for-errors
branch
from
8558727
to
6b1fcf0
Compare
caphrim007
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
caphrim007
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
…p based queries which do not appear to report errors elsewhere. Summary: Adds logging for reporting errors, which is useful for debugging config-map based queries which do not appear to report errors elsewhere Type of change: /kind fix Test Plan: Existing test cases should suffice as no new functionality is really added here. just additional logging. Signed-off-by: Tim Rupp <caphrim007@gmail.com>
caphrim007
force-pushed
the
fix/add-logging-for-errors
branch
from
3c58303
to
140d1a0
Compare
caphrim007
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
JamesMBartlett
approved these changes
Sep 18, 2023
ChinmayaSharma-hue
pushed a commit
to ChinmayaSharma-hue/pixie
that referenced
this pull request
Nov 9, 2023
pixie-io#1707) Summary: Adds logging for reporting errors, which is useful for debugging config-map based queries which do not appear to report errors elsewhere Type of change: /kind fix Test Plan: Existing test cases should suffice as no new functionality is really added here. just additional logging. Signed-off-by: Tim Rupp <caphrim007@gmail.com> Signed-off-by: Chinmay <chinmaysharma1020@gmail.com>
ChinmayaSharma-hue
pushed a commit
to ChinmayaSharma-hue/pixie
that referenced
this pull request
Nov 9, 2023
pixie-io#1707) Summary: Adds logging for reporting errors, which is useful for debugging config-map based queries which do not appear to report errors elsewhere Type of change: /kind fix Test Plan: Existing test cases should suffice as no new functionality is really added here. just additional logging. Signed-off-by: Tim Rupp <caphrim007@gmail.com> Signed-off-by: Chinmay <chinmaysharma1020@gmail.com>
ChinmayaSharma-hue
pushed a commit
to ChinmayaSharma-hue/pixie
that referenced
this pull request
Nov 9, 2023
pixie-io#1707) Summary: Adds logging for reporting errors, which is useful for debugging config-map based queries which do not appear to report errors elsewhere Type of change: /kind fix Test Plan: Existing test cases should suffice as no new functionality is really added here. just additional logging. Signed-off-by: Tim Rupp <caphrim007@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds logging for reporting errors, which is useful for debugging config-map based queries which do not appear to report errors elsewhere
Type of change: /kind fix
Test Plan: Existing test cases should suffice as no new functionality is really added here. just additional logging.