Refactor base colors to configurables directory. Allow customizing primary color for light and dark mode #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing primary color for light and dark mode Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
force-pushed
the
ddelnano/refactor-colors-and-allow-light-dark-mode-diff
branch
from
b99fa95
to
24ca5fa
Compare
NickLanam
approved these changes
Jun 27, 2024
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
force-pushed
the
ddelnano/refactor-colors-and-allow-light-dark-mode-diff
branch
from
1e2eb7c
to
7f5664a
Compare
NickLanam
approved these changes
Jun 27, 2024
ddelnano
deleted the
ddelnano/refactor-colors-and-allow-light-dark-mode-diff
branch
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
…imary color for light and dark mode (pixie-io#1957) Summary: Refactor base colors to configurables directory. Allow customizing primary color for light and dark mode This change makes it possible to have different main colors for light and dark mode. The contrast difference between the light mode background and the text color scores poorly with the [contrast checker](https://webaim.org/resources/contrastchecker/?fcolor=12D6D6&bcolor=F6F6F6). Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Tested UI to verify that it looks the same in light and dark mode - [x] Verified all references to `COLORS.PRIMARY[500]` have been updated with new structure --------- Signed-off-by: Dom Del Nano <ddelnano@gmail.com> GitOrigin-RevId: e0aa3e2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Refactor base colors to configurables directory. Allow customizing primary color for light and dark mode
This change makes it possible to have different main colors for light and dark mode. The contrast difference between the light mode background and the text color scores poorly with the contrast checker.
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Tested UI to verify that it looks the same in light and dark mode
COLORS.PRIMARY[500]have been updated with new structure