Fix path to cli artifacts and output file now that container volume mounts are removed #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounts are removed Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
aimichelle
approved these changes
Sep 11, 2024
ddelnano
deleted the
ddelnano/fix-path-to-px-artifact-for-package-building
branch
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
…ounts are removed (pixie-io#2019) GitOrigin-RevId: a68986a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix path to cli artifacts and output file now that container volume mounts are removed
In #2015, I forgot to account for the volume mounts used to place the
pxbuild artifacts in the container's working directory. This restores the filepath access that the containerized version had.Relevant Issues: #1993
Type of change: /kind bugfix
Test Plan: Reviewed the previous podman command more closely. Still needs to be validated with a successful production cli release.