Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes mv2 builds; simplifies workflows #8482

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

grahamlangford
Copy link
Collaborator

@grahamlangford grahamlangford commented May 20, 2024

What does this PR do?

  • Eliminates mv2 builds in CI

Discussion

  • Originally considered just changing the ci.yml to upload mv3 to Rainforest instead of mv2
  • And eliminate the Playwright runs for mv2
  • Decided there's really no reason to keep mv2 builds around

Future Work

  • Fix Rainforest tests that rely on the sidebar
  • Simplify manifest.json and manifest.mjs (can hardcode mv3 concerns)

Checklist

  • Designate a primary reviewer @BLoe

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44%. Comparing base (6d95047) to head (c55793a).
Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8482      +/-   ##
==========================================
- Coverage   73.47%   73.44%   -0.04%     
==========================================
  Files        1334     1352      +18     
  Lines       41259    41563     +304     
  Branches     7686     7799     +113     
==========================================
+ Hits        30316    30524     +208     
- Misses      10943    11039      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Playwright test results

passed  55 passed
flaky  1 flaky

Details

report  Open report ↗︎
stats  56 tests across 19 suites
duration  15 minutes, 51 seconds
commit  c55793a

Flaky tests

edge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller enabled auto-merge (squash) May 20, 2024 23:51
@twschiller twschiller disabled auto-merge May 20, 2024 23:51
@twschiller twschiller enabled auto-merge (squash) May 20, 2024 23:52
@twschiller twschiller disabled auto-merge May 20, 2024 23:52
@twschiller twschiller merged commit 3485a51 into main May 20, 2024
20 checks passed
@twschiller twschiller deleted the eliminate-mv2-builds branch May 20, 2024 23:52
@grahamlangford grahamlangford added this to the 2.0.0 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants