#8815 E2E test for sidebar partner auth #8862
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8862 +/- ##
==========================================
+ Coverage 74.24% 74.38% +0.13%
==========================================
Files 1332 1340 +8
Lines 40817 41198 +381
Branches 7634 7710 +76
==========================================
+ Hits 30306 30646 +340
- Misses 10511 10552 +41 ☔ View full report in Codecov by Sentry. |
Playwright test results
Details
Flaky testsedgeSetup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
…om/pixiebrix/pixiebrix-extension into bugfix/8815_connect_button_sidebar merge with origin
| try { | ||
| await connectLink.click(); | ||
| } catch { | ||
| // There is a known issue with Edge where clicking external links in the sidebar will implicitly cause the sidebar to be |
There was a problem hiding this comment.
One thing to consider is to only conditionally swallow the error if this test is being run in msedge.
| // Another msedge bug causes the browser to fail to open the extension console page from the sidebar until you refresh the page. | ||
| // "Error: This script should only be loaded in a browser extension." | ||
| await extensionConsolePage.reload(); | ||
| } |
There was a problem hiding this comment.
For now, I copied this logic from another test because I'm not sure how to extract it neatly into a POM since it spans two POMs (the sidebar and the extension console)
This is also only the second time we've had to do this so I propose waiting until we see this at least one more time before extracting
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?