Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android sample app #60

Merged
merged 2 commits into from
Nov 14, 2017
Merged

Fix Android sample app #60

merged 2 commits into from
Nov 14, 2017

Conversation

AbigailMcP
Copy link
Contributor

Includes a couple of fixes to the Android sample app:

  • Adding a .png icon file
  • Adding expected index.android.js entry point

Copy link
Contributor

@mcdaniel67 mcdaniel67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to pull locally and test, but ccoenraets's repo doesn't have good Android documentation. Only really had one point which could be taken as OOS. We could also consider adding instructions for Android in the Cavy example docs.

@@ -7,7 +7,7 @@
"test": "jest"
},
"dependencies": {
"cavy": "^0.1.0",
"cavy": "^0.4.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to knock out #55 at the same time. Not sure if it's totally out of scope for this change.

@jalada
Copy link
Contributor

jalada commented Nov 14, 2017

@mcdaniel67 you're right, the documentation is thin on the ground and a bit outdated. I'll add another note to pull in our own documentation. For now, you should be able to follow the standard process for setting up an app; the code is just JS.

@jalada jalada merged commit a0a31a0 into master Nov 14, 2017
@jalada jalada deleted the fix-android-sample-app branch November 14, 2017 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants