Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript & module assets Rewrite, v5 update #99

Merged
merged 94 commits into from
Sep 14, 2021
Merged

Typescript & module assets Rewrite, v5 update #99

merged 94 commits into from
Sep 14, 2021

Conversation

andrewstart
Copy link
Collaborator

@andrewstart andrewstart commented Mar 18, 2020 •
edited
Loading

All of the breaking changes in one go:

  • All source code in Typescript (significant, but not actually breaking)
  • Update for PixiJS v5
  • No longer modify existing PixiJS classes but subclass them instead
  • Replace asset format with new module-based one that doesn't rely on any global namespaces.
  • Fix an oddity where the Graphics closePath() shorthand overwrote the DisplayObject setColorTransform() shorthand.

Todo:

  • More testing (in existing projects, preferrably)
  • Update asset conversion script to try to go into .shapes.json files to replace "c" with "cp" and hole changes

@andrewstart
Initial set-up - bring over build process from pixi-particles (nothin…
3b36e89 
…g works yet).
@andrewstart
Convert mixins to TS and ES6 classes extending originals.
8db191b
@andrewstart
Continue conversion - changed files are mostly complete, have some ty…
7788aff 
…pe issues.
@andrewstart
More conversion progress. MovieClip has a few things to fix.
e129b7e
@andrewstart
Convert Scene to typescript.
cab35c7
@andrewstart
Fix tabs->spaces in Scene. Remove constructor as it only called super().
f497e48
@andrewstart
Convert Animator/AnimatorTimeline.
158edc1
@andrewstart
Fix errors in MovieClip.
9e42a53
@andrewstart
Fix some small errors.
dd29c2c
@andrewstart
Rename the former mixins to avoid conflicts in bundled .d.ts
37bdf91
@andrewstart
Update dts-bundle-generator to see if it fixed remaining .d.ts issue.
8ffe870 
It did not.
@andrewstart
Fix some references to PIXI namespace.
21acb68
@andrewstart
Change internal name of utils to fix .d.ts output issue.
8283d24
@andrewstart
Get .d.ts output fully working.
ab6fb25
@andrewstart
Rename 'mixin' classes on library export for nicer exports.
be0b39f
@andrewstart
Enable tree-shaking on IIFE built version.
f3128da
@andrewstart
Start fixing broken tests.
df73048
@andrewstart
Add shim for existing asset format. Fix Timeline issues.
3a45851
@andrewstart
Update floss, fix problems with image comparison in tests.
c4a4dad
@andrewstart
Clean up docs.
f886f80
@andrewstart
Fix closePath/setColorTransform shorthand shenanigans.
3c73ab3
@andrewstart
Fix npm audit issues.
bbd350b
@andrewstart
Drop pixi.js v4 support, add v5 support.
3c24dd5
@andrewstart
Change basic tests to use require(). Rename render tests to legacy.
e237cd1
@andrewstart
Remove global caches, set up new asset format, start updating tests.
92fc480
@andrewstart
Fix whitespace, some docs, note a breaking change in the readme.
3d27374
@andrewstart
Remove import type because typedoc was choking on it.
feafb98 
Turns out removing it doesn't harm anything - typescript correctly 
removes those type-only imports.
@andrewstart
Manual conversions of a couple more test files.
bb04793
@andrewstart
Add script for conversion of v1 assets to v2 assets.
d050f5e
@andrewstart
Fix asset conversion script, convert other test assets.
e251cfb
@andrewstart
Copy link
Collaborator Author

@bigtimebuddy @ericente I think this is ready to go. I'm not sure why that one rendering test failed on travis, as it passes locally.

@andrewstart andrewstart requested a review from ericente May 20, 2021 15:03
bigtimebuddy
bigtimebuddy approved these changes Jun 14, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
andrewstart
andrewstart commented Jun 14, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@dlawrence2060
Copy link

Can someone review this?

@bigtimebuddy
Copy link
Member

@andrewstart lets ship this

@andrewstart andrewstart merged commit dae195d into master Sep 14, 2021
@andrewstart andrewstart deleted the ts-and-v5-rewrite branch September 14, 2021 13:36
@jcward jcward mentioned this pull request Sep 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@ericente ericente Awaiting requested review from ericente

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@andrewstart @bigtimebuddy @pbalmasov @dlawrence2060