-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BevelFilter
rotation defaults to 0° instead of 45°
#456
Comments
This bug isn't there with Pixi 7 and Filters 5: https://jsfiddle.net/buo96kmv/ I haven't built it and made sure that this is the problem, but It looks like it's a degrees-to-radians conversion bug. filters/src/bevel/BevelFilter.ts Line 82 in ca0c344
and then again when Object.assign calls the setter: filters/src/bevel/BevelFilter.ts Line 125 in ca0c344
filters/src/bevel/BevelFilter.ts Lines 133 to 137 in ca0c344
|
Good catch. |
The constructor ignores the rotation value, but setting it after initialization works: https://jsfiddle.net/3anhs0pw/
Also, to be consistent, I think
rotation
values should be in radians like in Pixi, whileangle
values would be in degrees.The text was updated successfully, but these errors were encountered: