-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ColorMapFilter #136
Add ColorMapFilter #136
Conversation
online demo : http://fatidol.com/pixi-filters/ |
Can we rename this to ColorMapFilter? |
or ColorMappingFilter ? How do you think about it , @ivanpopelyshev ? |
Many of the other filters names are nouns, "color mapping" feels inconsistent. |
mapping is also a noun. mapping [ 'mæpiŋ ] example: ORM , Object Relational Mapping ( in ORM , mapping is a noun) |
I stand corrected! I read it more as an action. I'm fine with either, but not ColorAdjustFilter. |
@finscn could you rename? Then I will merge. |
ColorMapFilter or ColorMappingFilter ? And if call this filter |
I like ColorMapFilter because it's shorter, but whichever you prefer. Also, no need to change AdjustmentFilter, that's fine for now. |
OK. I'll use |
df79933
to
4708ad1
Compare
Thanks @finscn, good work. |
More details at : #61
inspired by :
https://www.youtube.com/watch?v=rfQ8rKGTVlg#t=25m03s
https://github.com/hughsk/webgl-texture3d
https://www.defold.com/tutorials/grading/