Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColorMapFilter #136

Merged
merged 5 commits into from
Feb 27, 2018
Merged

Conversation

finscn
Copy link
Contributor

@finscn finscn commented Jan 22, 2018

@finscn
Copy link
Contributor Author

finscn commented Jan 25, 2018

online demo : http://fatidol.com/pixi-filters/

@bigtimebuddy
Copy link
Member

Can we rename this to ColorMapFilter?

@finscn
Copy link
Contributor Author

finscn commented Feb 25, 2018

or ColorMappingFilter ? How do you think about it , @ivanpopelyshev ?

@bigtimebuddy
Copy link
Member

Many of the other filters names are nouns, "color mapping" feels inconsistent.

@finscn
Copy link
Contributor Author

finscn commented Feb 25, 2018

mapping is also a noun.

mapping [ 'mæpiŋ ]
n.
a function such that for every element of one set there is a unique element of another set

example: ORM , Object Relational Mapping ( in ORM , mapping is a noun)

@bigtimebuddy
Copy link
Member

I stand corrected! I read it more as an action.

I'm fine with either, but not ColorAdjustFilter.

@bigtimebuddy bigtimebuddy added this to the v2.6.0 milestone Feb 25, 2018
@bigtimebuddy
Copy link
Member

@finscn could you rename? Then I will merge.

@finscn
Copy link
Contributor Author

finscn commented Feb 26, 2018

ColorMapFilter or ColorMappingFilter ?

And if call this filter ColorMapFilter/ColorMappingFilter , shall we change the AdjustmentFilter to ColorAdjustFilter/ColorAdjustmentFilter ?

@bigtimebuddy
Copy link
Member

I like ColorMapFilter because it's shorter, but whichever you prefer. Also, no need to change AdjustmentFilter, that's fine for now.

@finscn
Copy link
Contributor Author

finscn commented Feb 27, 2018

OK. I'll use ColorMapFilter , because there is a filter named SimpleLightMapFilter.
both map is better than one map & one mapping.

@finscn finscn changed the title Add ColorAdjustFilter Add ColorMapFilter Feb 27, 2018
@bigtimebuddy bigtimebuddy merged commit bdfdde9 into pixijs:master Feb 27, 2018
@bigtimebuddy
Copy link
Member

Thanks @finscn, good work.

@finscn finscn deleted the add-ColorAdjustFilter branch February 27, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants