Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Missing gradient-parser types #455

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix: Missing gradient-parser types #455

merged 1 commit into from
Apr 10, 2024

Conversation

bigtimebuddy
Copy link
Member

Fixes #454

Julien-Marcou
Julien-Marcou approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@Julien-Marcou Julien-Marcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if we wanted to add a "typing" dependency into the non-dev dependencies, that's why I didn't made the PR myself 😅 but looks good to me

@bigtimebuddy
Copy link
Member Author

Yeah, we do this in the main project for a handful of types that are exported:
https://github.com/pixijs/pixijs/blob/dev/package.json#L58-L68

@bigtimebuddy bigtimebuddy merged commit fb69138 into main Apr 10, 2024
2 checks passed
@bigtimebuddy bigtimebuddy deleted the fix/gradient-parser-types branch April 10, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julien-Marcou Julien-Marcou Julien-Marcou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find module 'gradient-parser'
2 participants
@bigtimebuddy @Julien-Marcou