Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Fix landscape bar issue on iOS #102

Closed
wants to merge 1 commit into from
Closed

Conversation

alamboley
Copy link
Contributor

Related to #101, it shouldn't be an absolute position but a fixed one! Do you see any downside changing this?

Related to pixijs#101, it shouldn't be an `absolute` position but a `fixed` one! Do you see any downside changing this?
@adireddy

This comment was marked as spam.

@alamboley
Copy link
Contributor Author

alamboley commented Jan 5, 2017

I understand that changing to fixed could break some project but having a default to absolute which is wrong for iOS is a big deal (it was really hard to find the issue on the web...)! And I'm pretty sure that most of the pixi project are "fullscreen". It seems that Pixijs doesn't specify a position https://github.com/pixijs/pixi.js/blob/dev/src/core/renderers/SystemRenderer.js#L92. I would prefer no position mentioned than a problematic one.

@alamboley alamboley changed the title Fix lanscape bar issue on iOS Fix landscape bar issue on iOS Jan 5, 2017
@adireddy

This comment was marked as spam.

@alamboley
Copy link
Contributor Author

Perfect for me 👍

@alamboley
Copy link
Contributor Author

Just saw your changes, perfect! Could you create a new release please?

@alamboley alamboley closed this Jan 5, 2017
@adireddy

This comment was marked as spam.

@adireddy

This comment was marked as spam.

@alamboley alamboley deleted the patch-3 branch January 5, 2017 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants