Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: compressed textures priorities #10219

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

ddenisyuk
Copy link

@ddenisyuk ddenisyuk commented Feb 15, 2024

Description of change

#10213

Compressed textures priorities changed to: 'basis', 'bc7', 'bc6h', 'astc', 'etc2', 'bc5', 'bc4', 'bc3', 'bc2', 'bc1', 'eac'

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@ddenisyuk ddenisyuk changed the title Compressed textures priorities [v8] Compressed textures priorities Feb 15, 2024
Copy link

codesandbox-ci bot commented Feb 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit accf9a9:

Sandbox Source
pixi.js-sandbox Configuration

@ddenisyuk ddenisyuk marked this pull request as ready for review February 15, 2024 11:27
…stc', 'etc2', 'bc5', 'bc4', 'bc3', 'bc2', 'bc1', 'eac'
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @ddenisyuk

@ddenisyuk
Copy link
Author

@GoodBoyDigital Would it be acceptable to include changes similar to those in spritesheetAsset.ts within the this PR, or should I open a new one for that purpose?

@Zyie
Copy link
Member

Zyie commented Feb 20, 2024

@GoodBoyDigital Would it be acceptable to include changes similar to those in spritesheetAsset.ts within the this PR, or should I open a new one for that purpose?

If you could port that PR entirely over to v8 as a new PR that would be great. I believe it is an issue for both v7 and v8

@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Feb 20, 2024
@Zyie Zyie changed the title [v8] Compressed textures priorities Fix: compressed textures priorities Feb 20, 2024
@ddenisyuk
Copy link
Author

ddenisyuk commented Feb 20, 2024

@GoodBoyDigital Would it be acceptable to include changes similar to those in spritesheetAsset.ts within the this PR, or should I open a new one for that purpose?

If you could port that PR entirely over to v8 as a new PR that would be great. I believe it is an issue for both v7 and v8

v8 looks good, issue has been fixed in 76437e9

So only test and spritesheetAsset.ts should be ported; I'll make a new PR

UPD: #10232

@Zyie Zyie merged commit e3c9b9d into pixijs:next-v8 Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants