-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: compressed textures priorities #10219
Fix: compressed textures priorities #10219
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit accf9a9:
|
…stc', 'etc2', 'bc5', 'bc4', 'bc3', 'bc2', 'bc1', 'eac'
2e411b5
to
b48e4aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @ddenisyuk
@GoodBoyDigital Would it be acceptable to include changes similar to those in spritesheetAsset.ts within the this PR, or should I open a new one for that purpose? |
If you could port that PR entirely over to v8 as a new PR that would be great. I believe it is an issue for both v7 and v8 |
v8 looks good, issue has been fixed in 76437e9 So only test and spritesheetAsset.ts should be ported; I'll make a new PR UPD: #10232 |
Description of change
#10213
Compressed textures priorities changed to: 'basis', 'bc7', 'bc6h', 'astc', 'etc2', 'bc5', 'bc4', 'bc3', 'bc2', 'bc1', 'eac'
Pre-Merge Checklist
npm run lint
)npm run test
)