Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of bugs with context loss. For debugging, you can simulate context loss like so (in Chrome);
I also did a bit of code tidy in WebGLRenderer. Here is a run-down of the issues that were fixed:
So if another shader was previously bound (i.e. line strip) this would cause errors on context restore.
There are still some outstanding bugs:
PIXI._restoreBatchs
,PIXI._returnBatch
andPIXI._getBatch
seem like they duplicate functionality that should be in WebGLRenderGroup. This should really be changed. Also, static globals should be removed to better support multiple canvases and contexts, and make a cleaner API.Also, if batch features ever become part of the public API, we should use the naming "batches" instead of "batchs".