Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unattach textures from framebuffer that are no longer used and … #9345

Open
wants to merge 1 commit into
base: v7.x
Choose a base branch
from

Conversation

dev7355608
Copy link
Collaborator

… don't attach more than MAX_COLOR_ATTACHMENTS color textures.

If a color texture or the depth texture is removed, then we need to make sure their attachments are cleared, if they are not overridden by other attachments.

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c68529e:

Sandbox Source
pixi.js-sandbox Configuration

@bigtimebuddy
Copy link
Member

Have you got a clear use-case for this? Are you modifying framebuffers on the fly?

@dev7355608
Copy link
Collaborator Author

No, but I thought it should work. It's possible to add color textures after the first bind, but removing attachments isn't possible unless the framebuffer is disposed. Either both adding and removing should be possible after the first bind or neither, right?

@bigtimebuddy bigtimebuddy added the 🥶 Low Priority Generally issues or PRs that don’t need to make it into the next release. label May 24, 2023
@Zyie Zyie deleted the branch v7.x March 5, 2024 17:16
@Zyie Zyie closed this Mar 5, 2024
@Zyie Zyie reopened this Mar 5, 2024
@Zyie Zyie changed the base branch from dev to v7.x March 5, 2024 18:07
@Zyie Zyie added the v7 label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥶 Low Priority Generally issues or PRs that don’t need to make it into the next release. v7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants