Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: optimisation and fix for clipping and blend modes #11

Merged
merged 5 commits into from
Jun 6, 2024
Merged

chore: optimisation and fix for clipping and blend modes #11

merged 5 commits into from
Jun 6, 2024

Conversation

GoodBoyDigital
Copy link
Member

@GoodBoyDigital GoodBoyDigital commented Jun 6, 2024 •
edited

Refactored things a bit to make them run faster and a few other bits!

  • 30% faster than the current v8 (which was faster than v7 already!)
  • uses less memory, about 25% than current v8
  • Better validation of spine updates, if the meshes / draw order remain the same then no rebuild is triggered
  • spine bone / attachment updates only happen once per state update at the point the data is needed (eg measuring or rendering). No heavy lifting if state is not updated
  • Added support for blend modes
  • Fixed clipping - so it works properly now (and is faster more memory efficient)

@GoodBoyDigital
- optimise spine to run better. 33% faster ish!
9918800 
- only updating meshes once per state application when required (measuring or rendering)
@GoodBoyDigital
lint
5ba8bb6
@GoodBoyDigital
tidy up
ae46a8a
@GoodBoyDigital
final tidy up
754f38c
@GoodBoyDigital GoodBoyDigital requested a review from Zyie June 6, 2024 08:21
@GoodBoyDigital
Copy link
Member Author

cc @badlogic. would be great to get your eyes on this one if you get a mo! Cheers!

@GoodBoyDigital GoodBoyDigital changed the title Chore/optimisation chore: optimisation and feature fixing Jun 6, 2024
@GoodBoyDigital GoodBoyDigital changed the title chore: optimisation and feature fixing chore: optimisation and fix for clipping and blend modes Jun 6, 2024
@Zyie @GoodBoyDigital
chore: update to esoteric api naming (#12)
8f4d510 
Co-authored-by: Mat Groves <mat.groves@play.co>
@Zyie Zyie merged commit a75213c into chore/attachToSlot Jun 6, 2024
2 checks passed
@Zyie Zyie deleted the chore/optimisation branch June 6, 2024 14:35
Zyie pushed a commit that referenced this pull request Jun 6, 2024
@GoodBoyDigital
feat: add addSlotObject, fix clipping and blend modes (#10)
0eede71 
Co-authored-by: Mat Groves <mat.groves@play.co>
Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>
fix for clipping and blend modes (#11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zyie Zyie Awaiting requested review from Zyie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GoodBoyDigital @Zyie