Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tint and spine skeleton/slot/attachment color #28

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: tint and spine skeleton/slot/attachment color #28

merged 1 commit into from
Aug 1, 2024

Conversation

davidetan
Copy link
Contributor

@davidetan davidetan commented Jul 25, 2024 •
edited
Loading

This PR should fix two issues about colors:

  • Fix the tint issue reported here: Bug: tint is not correct #18
  • Fix the final attachment color. The attachment color is the result of the skeleton, slot and attachment color. Previously only the slot color was used. You can see this from the white part in the hair of the girl in this example. Hair is colored using the attachment color, not the slot color.

@davidetan davidetan mentioned this pull request Jul 29, 2024
Closed
GoodBoyDigital
GoodBoyDigital approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely stuff! Thanks @davidetan 👍

@GoodBoyDigital GoodBoyDigital merged commit 9f697b1 into pixijs:main Aug 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoodBoyDigital GoodBoyDigital GoodBoyDigital approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidetan @GoodBoyDigital