Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of problem with clipping:
spinePipe.addRenderable
is called with acacheData.clippedData.vertexCount
set at0
, butcacheData.clippedData.vertices.length
is bigger than0
, it was still added to the batch, generating aGL_INVALID_OPERATION: Insufficient buffer size.
on webgl and aCalling [RenderPassEncoder (unlabeled)].Draw with an index count of 0 is unusual.
on webgpuspinePipe.updateRenderable
is called, thebatcher.updateElement
was called regardless of the fact the attachment has zero clipped vertices to draw; however, thevertexSize
of theBatchableSpineSlot
is never set to zero becuaseaddRenderable
set it only if vertices are more than zero. I added an if intoupdateRenderable
, otherwise we can move thebatchableSpineSlot.setData
outside the if in theaddRenderable
I'm not an expert of
RenderPipe
, so let me know if I did some wrong assumption :)