Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite build system #149

Merged
merged 18 commits into from
Mar 21, 2023
Merged

Vite build system #149

merged 18 commits into from
Mar 21, 2023

Conversation

steel97
Copy link
Collaborator

@steel97 steel97 commented Mar 9, 2023

This PR made to simplify build system, remove eslint warnings and also remove packages which contains vulnerabilities reported by npm during install.

What has been done:

  • old build system replaced with vite (also removed peerDependencies and outdated rollup plugins)
  • moved eslint config from package.json to .eslintrc.cjs
  • floss replaced with vitest
  • updated example code in readme to match new asset loading API
  • formatted all sources to eliminate eslint warnings
  • replaced yarn with npm in github actions

My vue3-pixi-tilemap example updated to use this branch: https://steel97.github.io/vue3-pixi-tilemap/

@ivanpopelyshev
Copy link
Collaborator

You can merge it now, right?

@steel97
Copy link
Collaborator Author

steel97 commented Mar 9, 2023

Yes I have permissions to merge it, thanks!

@ivanpopelyshev ivanpopelyshev merged commit 2f2387b into pixijs:master Mar 21, 2023
@YunYouJun
Copy link
Contributor

I clone this repo, and npm run start, but get PIXI.CanvasRenderer.registerPlugin is not a function.

Can you start this project?

@steel97
Copy link
Collaborator Author

steel97 commented Mar 23, 2023

@YunYouJun rpgmaker example is not yet updated. You may try basic example (navigate to basic.html after npm run start)
изображение

@YunYouJun
Copy link
Contributor

I have an idea, I think we can build a demo based on vite directly by ts, so when npm run start, no need to build before it.

@steel97
Copy link
Collaborator Author

steel97 commented Mar 23, 2023

yes we can do that, but in this case examples won't run without vite (currently examples can be launched standalone)

@YunYouJun
Copy link
Contributor

yes we can do that, but in this case examples won't run without vite (currently examples can be launched standalone)

We can write a yml for github-action. Deploy it in gh-pages branch or build and preview by vercel/netlify/cloudflare pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants