Fix: Incorrect ScrollBox Bidirectional Vertical Flow #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbazukun123
requested review from
Zyie,
GoodBoyDigital and
CyberDex
as code owners
Zyie
approved these changes
May 22, 2024
CyberDex
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current for bidirectional scroll box, item will flow down vertically using it's own height but a row can have varying height so temporarily row's
maxHeightvalue is stored to accommodate this.Behaviour Preview
Before
The overflowed item flows to the new line only using its height.
Screen.Recording.2024-05-21.at.16.10.43.mov
After
The overflowed item flows to the new line only the row's height (of the tallest item)
Screen.Recording.2024-05-21.at.16.11.08.mov