Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Preparation #4

Merged
merged 11 commits into from
Jan 10, 2023
Merged

Release Preparation #4

merged 11 commits into from
Jan 10, 2023

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Jan 9, 2023

This is a rather large PR, sorry about that!
This PR contains nearly all the changes needed to get this project working for use in the pixi games!

Changes:

  • Updates repo to use @pixi/extension-scripts for building the project
  • Updated project to pixi v7
  • Updated to use latest pixi-storybook
  • Generating docs from a github action now
  • Added husky for pre-commit linting
  • Added github actions for testing and releases

Known Issues

Documentation Generation

Since we are using @pixi/extension-scripts it uses webdoc to generate API docs. We need to format our documentation so that it works properly

Pixi Interaction Changes

Because of the changes to interaction in v7 our select, scrollbox, and sliders do not work unless you explicitly set this:

app.renderer.events.rootBoundary.moveOnAll = true

This changes the pointermove behaviour to work like it did in v6 of pixi however its only a temporary solution and will need looking into before we release to the world

Storybook PR

I am waiting for this PR to be reviewed so that we can remove the patch-package hack from this repo

Minor Improvements

Below is a list of improvements we should make before releasing to the public

  • remove typed-signals. We should dispatch a pixi event instead
  • trackpad options need to be exposed in scrollbox
  • add ability to set hover state for checkboxes, radio group, input,
  • select component background is stretched when using sprite. (Maybe this needs to be a tiling-sprite)?

Copy link
Member

@CyberDex CyberDex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Zyie Zyie merged commit ed9c4df into main Jan 10, 2023
@Zyie Zyie deleted the release-prep branch January 10, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants