Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField を TextField と TextArea に分ける #287

Merged
merged 16 commits into from
Jun 21, 2023

Conversation

fsubal
Copy link
Member

@fsubal fsubal commented Mar 29, 2023

Reverts #286

closes: #164

ref: #211 #209

やったこと

  • storybook 上で TextField の中身を分割して TextField と TextArea に分けた

動作確認環境

  • storybook

チェックリスト

不要なチェック項目は消して構いません

  • 破壊的変更がある場合には、対象のパッケージのメジャーバージョンが上がっていることを確認した
  • 追加したコンポーネントが index.ts から再 export されている
  • README やドキュメントに影響があることを確認した

備考

  • めちゃくちゃ破壊的変更なのでこれを merge したあとどこの version に混ぜるかは考えたほうが良さそうだと思いました。

@fsubal
Copy link
Member Author

fsubal commented Mar 29, 2023

TODO: ドキュメントサイトも変更する

@github-actions
Copy link

github-actions bot commented Mar 29, 2023

Size Change: -3.16 kB (-1%)

Total Size: 550 kB

Filename Size Change
./packages/react/dist/components/Button/index.d.ts 660 B +4 B (+1%)
./packages/react/dist/components/DropdownSelector/index.d.ts 707 B -715 B (-50%) 🏆
./packages/react/dist/components/DropdownSelector/index.story.d.ts 482 B -585 B (-55%) 🏆
./packages/react/dist/components/DropdownSelector/Listbox.d.ts 0 B -422 B (removed) 🏆
./packages/react/dist/components/DropdownSelector/ListBoxSection.d.ts 0 B -246 B (removed) 🏆
./packages/react/dist/components/DropdownSelector/Option.d.ts 0 B -351 B (removed) 🏆
./packages/react/dist/components/TextField/index.d.ts 1.18 kB -557 B (-32%) 🎉
./packages/react/dist/components/TextField/index.story.d.ts 0 B -1.22 kB (removed) 🏆
./packages/react/dist/index.cjs.js 69 kB -1.9 kB (-3%)
./packages/react/dist/index.d.ts 1.94 kB +121 B (+7%) 🔍
./packages/react/dist/index.esm.js 60.9 kB -1.24 kB (-2%)
./packages/react/dist/components/DropdownSelector/OptionItem.d.ts 228 B +228 B (new file) 🆕
./packages/react/dist/components/DropdownSelector/utils/focusIfHTMLLIElement.d.ts 291 B +291 B (new file) 🆕
./packages/react/dist/components/DropdownSelector/utils/handleFocusByKeyBoard.d.ts 246 B +246 B (new file) 🆕
./packages/react/dist/components/TextArea/index.d.ts 1.14 kB +1.14 kB (new file) 🆕
./packages/react/dist/components/TextArea/TextArea.story.d.ts 989 B +989 B (new file) 🆕
./packages/react/dist/components/TextField/TextField.story.d.ts 1.06 kB +1.06 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./packages/foundation/dist/border-radius.d.ts 692 B
./packages/foundation/dist/breakpoint.d.ts 225 B
./packages/foundation/dist/color.d.ts 171 B
./packages/foundation/dist/effect.d.ts 1.08 kB
./packages/foundation/dist/grid.d.ts 396 B
./packages/foundation/dist/index.cjs.js 2.82 kB
./packages/foundation/dist/index.d.ts 230 B
./packages/foundation/dist/index.esm.js 1.44 kB
./packages/foundation/dist/spacing.d.ts 305 B
./packages/foundation/dist/typography.d.ts 790 B
./packages/icons-cli/dist/index.js 20.3 kB
./packages/icons/dist/charcoalIconFiles.d.ts 4.54 kB
./packages/icons/dist/index.cjs.js 9.47 kB
./packages/icons/dist/index.d.ts 478 B
./packages/icons/dist/index.esm.js 7.96 kB
./packages/icons/dist/loaders/CharcoalIconFilesLoader.d.ts 7.17 kB
./packages/icons/dist/loaders/CustomIconLoader.d.ts 417 B
./packages/icons/dist/loaders/index.d.ts 181 B
./packages/icons/dist/loaders/Loadable.d.ts 98 B
./packages/icons/dist/loaders/PixivIconLoadError.d.ts 153 B
./packages/icons/dist/PixivIcon.d.ts 1.46 kB
./packages/icons/dist/PixivIcon.story.d.ts 880 B
./packages/icons/dist/PixivIcon.test.d.ts 55 B
./packages/icons/dist/ssr.d.ts 75 B
./packages/react-sandbox/dist/_lib/compat.d.ts 422 B
./packages/react-sandbox/dist/components/Carousel/index.d.ts 1.34 kB
./packages/react-sandbox/dist/components/Carousel/index.story.d.ts 208 B
./packages/react-sandbox/dist/components/CarouselButton/index.d.ts 619 B
./packages/react-sandbox/dist/components/CarouselButton/index.story.d.ts 343 B
./packages/react-sandbox/dist/components/Filter/index.d.ts 1.11 kB
./packages/react-sandbox/dist/components/Filter/index.story.d.ts 374 B
./packages/react-sandbox/dist/components/HintText/index.d.ts 293 B
./packages/react-sandbox/dist/components/HintText/index.story.d.ts 312 B
./packages/react-sandbox/dist/components/icons/Base.d.ts 701 B
./packages/react-sandbox/dist/components/icons/DotsIcon.d.ts 282 B
./packages/react-sandbox/dist/components/icons/InfoIcon.d.ts 87 B
./packages/react-sandbox/dist/components/icons/NextIcon.d.ts 281 B
./packages/react-sandbox/dist/components/icons/WedgeIcon.d.ts 462 B
./packages/react-sandbox/dist/components/Layout/index.d.ts 2.06 kB
./packages/react-sandbox/dist/components/Layout/index.story.d.ts 402 B
./packages/react-sandbox/dist/components/LeftMenu/index.d.ts 382 B
./packages/react-sandbox/dist/components/MenuListItem/index.d.ts 1.78 kB
./packages/react-sandbox/dist/components/MenuListItem/index.story.d.ts 725 B
./packages/react-sandbox/dist/components/Pager/index.d.ts 492 B
./packages/react-sandbox/dist/components/Pager/index.story.d.ts 866 B
./packages/react-sandbox/dist/components/SwitchCheckbox/index.d.ts 335 B
./packages/react-sandbox/dist/components/SwitchCheckbox/index.story.d.ts 436 B
./packages/react-sandbox/dist/components/TextEllipsis/helper.d.ts 235 B
./packages/react-sandbox/dist/components/TextEllipsis/index.d.ts 381 B
./packages/react-sandbox/dist/components/TextEllipsis/index.story.d.ts 345 B
./packages/react-sandbox/dist/components/WithIcon/index.d.ts 1.07 kB
./packages/react-sandbox/dist/components/WithIcon/index.story.d.ts 604 B
./packages/react-sandbox/dist/foundation/contants.d.ts 207 B
./packages/react-sandbox/dist/foundation/hooks.d.ts 1.04 kB
./packages/react-sandbox/dist/foundation/support.d.ts 131 B
./packages/react-sandbox/dist/foundation/utils.d.ts 613 B
./packages/react-sandbox/dist/hooks/index.d.ts 148 B
./packages/react-sandbox/dist/index.cjs.js 63.2 kB
./packages/react-sandbox/dist/index.d.ts 1.34 kB
./packages/react-sandbox/dist/index.esm.js 54.4 kB
./packages/react-sandbox/dist/misc/storybook-helper.d.ts 343 B
./packages/react-sandbox/dist/styled.d.ts 12.3 kB
./packages/react/dist/_lib/compat.d.ts 413 B
./packages/react/dist/_lib/index.d.ts 679 B
./packages/react/dist/components/a11y.test.d.ts 50 B
./packages/react/dist/components/Button/index.story.d.ts 1.27 kB
./packages/react/dist/components/Checkbox/index.d.ts 717 B
./packages/react/dist/components/Checkbox/index.story.d.ts 533 B
./packages/react/dist/components/Clickable/index.d.ts 742 B
./packages/react/dist/components/Clickable/index.story.d.ts 363 B
./packages/react/dist/components/DropdownSelector/Divider.d.ts 197 B
./packages/react/dist/components/DropdownSelector/DropdownPopover.d.ts 459 B
./packages/react/dist/components/FieldLabel/index.d.ts 465 B
./packages/react/dist/components/Icon/index.d.ts 493 B
./packages/react/dist/components/Icon/index.story.d.ts 4.95 kB
./packages/react/dist/components/IconButton/index.d.ts 579 B
./packages/react/dist/components/IconButton/index.story.d.ts 818 B
./packages/react/dist/components/LoadingSpinner/index.d.ts 506 B
./packages/react/dist/components/LoadingSpinner/index.story.d.ts 318 B
./packages/react/dist/components/Modal/index.d.ts 1.67 kB
./packages/react/dist/components/Modal/index.story.d.ts 839 B
./packages/react/dist/components/Modal/ModalPlumbing.d.ts 510 B
./packages/react/dist/components/MultiSelect/context.d.ts 395 B
./packages/react/dist/components/MultiSelect/index.d.ts 899 B
./packages/react/dist/components/MultiSelect/index.story.d.ts 1.73 kB
./packages/react/dist/components/MultiSelect/index.test.d.ts 51 B
./packages/react/dist/components/Radio/index.d.ts 892 B
./packages/react/dist/components/Radio/index.story.d.ts 798 B
./packages/react/dist/components/Radio/index.test.d.ts 51 B
./packages/react/dist/components/SegmentedControl/index.d.ts 698 B
./packages/react/dist/components/SegmentedControl/index.story.d.ts 497 B
./packages/react/dist/components/SegmentedControl/RadioGroupContext.d.ts 345 B
./packages/react/dist/components/Switch/index.d.ts 418 B
./packages/react/dist/components/Switch/index.story.d.ts 415 B
./packages/react/dist/components/TagItem/index.d.ts 1.14 kB
./packages/react/dist/components/TagItem/index.story.d.ts 1.11 kB
./packages/react/dist/core/CharcoalProvider.d.ts 592 B
./packages/react/dist/core/ComponentAbstraction.d.ts 928 B
./packages/react/dist/core/OverlayProvider.d.ts 101 B
./packages/react/dist/core/SSRProvider.d.ts 88 B
./packages/react/dist/styled.d.ts 12.3 kB
./packages/styled/dist/builders/border.d.ts 699 B
./packages/styled/dist/builders/borderRadius.d.ts 440 B
./packages/styled/dist/builders/colors.d.ts 1.3 kB
./packages/styled/dist/builders/elementEffect.d.ts 533 B
./packages/styled/dist/builders/o.d.ts 5.91 kB
./packages/styled/dist/builders/outline.d.ts 638 B
./packages/styled/dist/builders/size.d.ts 1.19 kB
./packages/styled/dist/builders/spacing.d.ts 1.17 kB
./packages/styled/dist/builders/transition.d.ts 287 B
./packages/styled/dist/builders/typography.d.ts 624 B
./packages/styled/dist/defineThemeVariables.test.d.ts 66 B
./packages/styled/dist/factories/lib.d.ts 3.96 kB
./packages/styled/dist/helper.d.ts 2.01 kB
./packages/styled/dist/index.cjs.js 26.4 kB
./packages/styled/dist/index.d.ts 6.24 kB
./packages/styled/dist/index.esm.js 23.9 kB
./packages/styled/dist/index.story.d.ts 561 B
./packages/styled/dist/index.test.d.ts 73 B
./packages/styled/dist/internals/index.d.ts 1.6 kB
./packages/styled/dist/SetThemeScript.d.ts 905 B
./packages/styled/dist/storyHelper.d.ts 299 B
./packages/styled/dist/TokenInjector.d.ts 494 B
./packages/styled/dist/util.d.ts 4.17 kB
./packages/tailwind-config/dist/_lib/compat.d.ts 413 B
./packages/tailwind-config/dist/_lib/TailwindBuild.d.ts 750 B
./packages/tailwind-config/dist/colors/plugin.d.ts 443 B
./packages/tailwind-config/dist/colors/plugin.test.d.ts 52 B
./packages/tailwind-config/dist/colors/toTailwindConfig.d.ts 394 B
./packages/tailwind-config/dist/colors/toTailwindConfig.test.d.ts 62 B
./packages/tailwind-config/dist/colors/utils.d.ts 347 B
./packages/tailwind-config/dist/docs/borderRadius/BorderRadius.d.ts 114 B
./packages/tailwind-config/dist/docs/borderRadius/index.d.ts 175 B
./packages/tailwind-config/dist/docs/colors/Colors.d.ts 102 B
./packages/tailwind-config/dist/docs/colors/index.d.ts 201 B
./packages/tailwind-config/dist/docs/colors/TextBgColor.story.d.ts 666 B
./packages/tailwind-config/dist/docs/colors/TextColors.d.ts 110 B
./packages/tailwind-config/dist/docs/gradient/Gradients.d.ts 108 B
./packages/tailwind-config/dist/docs/gradient/index.d.ts 433 B
./packages/tailwind-config/dist/docs/gradient/utils.d.ts 120 B
./packages/tailwind-config/dist/docs/index.d.ts 360 B
./packages/tailwind-config/dist/docs/screens/index.d.ts 160 B
./packages/tailwind-config/dist/docs/screens/Screens.d.ts 104 B
./packages/tailwind-config/dist/docs/spacing/index.d.ts 160 B
./packages/tailwind-config/dist/docs/spacing/Spacing.d.ts 104 B
./packages/tailwind-config/dist/docs/typography/HalfLeading.d.ts 112 B
./packages/tailwind-config/dist/docs/typography/index.d.ts 346 B
./packages/tailwind-config/dist/docs/typography/Sizes.d.ts 100 B
./packages/tailwind-config/dist/foundation.d.ts 360 B
./packages/tailwind-config/dist/gradient/plugin.d.ts 816 B
./packages/tailwind-config/dist/gradient/plugin.test.d.ts 52 B
./packages/tailwind-config/dist/index.cjs.js 11.5 kB
./packages/tailwind-config/dist/index.d.ts 373 B
./packages/tailwind-config/dist/index.esm.js 9.6 kB
./packages/tailwind-config/dist/index.test.d.ts 51 B
./packages/tailwind-config/dist/types.d.ts 855 B
./packages/tailwind-config/dist/typography/plugin.d.ts 146 B
./packages/tailwind-config/dist/util.d.ts 656 B
./packages/tailwind-diff/dist/commands/check.d.ts 296 B
./packages/tailwind-diff/dist/commands/check.js 4.37 kB
./packages/tailwind-diff/dist/commands/dump.d.ts 185 B
./packages/tailwind-diff/dist/commands/dump.js 1.26 kB
./packages/tailwind-diff/dist/defer.d.ts 164 B
./packages/tailwind-diff/dist/defer.js 815 B
./packages/tailwind-diff/dist/index.d.ts 46 B
./packages/tailwind-diff/dist/index.js 1.84 kB
./packages/tailwind-diff/dist/packageManager.d.ts 323 B
./packages/tailwind-diff/dist/packageManager.js 1.85 kB
./packages/tailwind-diff/dist/style.d.ts 436 B
./packages/tailwind-diff/dist/style.js 2.68 kB
./packages/tailwind-diff/dist/withPackages.d.ts 464 B
./packages/tailwind-diff/dist/withPackages.js 3.24 kB
./packages/theme/dist/abstract-theme.d.ts 1.19 kB
./packages/theme/dist/default.d.ts 163 B
./packages/theme/dist/index.cjs.js 5.17 kB
./packages/theme/dist/index.d.ts 121 B
./packages/theme/dist/index.esm.js 3.48 kB
./packages/theme/dist/theme.d.ts 2.87 kB
./packages/utils/dist/index.cjs.js 6.24 kB
./packages/utils/dist/index.d.ts 3.17 kB
./packages/utils/dist/index.esm.js 4.51 kB

compressed-size-action

@fsubal
Copy link
Member Author

fsubal commented Apr 19, 2023

3.0.0 のブランチにマージする

@fsubal fsubal force-pushed the revert-286-revert-211-issue-209 branch from 8019cec to bc6b64d Compare May 24, 2023 12:16
@fsubal fsubal changed the base branch from main to v3.0.0 May 24, 2023 12:16
@fsubal fsubal force-pushed the revert-286-revert-211-issue-209 branch from d0ee09b to 0898a67 Compare May 24, 2023 12:22
@fsubal fsubal self-assigned this May 24, 2023
@fsubal fsubal force-pushed the revert-286-revert-211-issue-209 branch from 0898a67 to 77af81a Compare June 6, 2023 14:26
@fsubal fsubal changed the title [BREAKING CHANGE] TextField を TextField と TextArea に分ける TextField を TextField と TextArea に分ける Jun 6, 2023
@fsubal fsubal temporarily deployed to preview-channel June 6, 2023 14:36 — with GitHub Actions Inactive
@fsubal fsubal requested a review from toshusai June 6, 2023 14:37
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Visit the preview URL for this PR (updated for commit 4eef024):

https://pixiv-charcoal-web--pr287-revert-286-revert-21-cexkdxqd.web.app

(expires Wed, 28 Jun 2023 07:30:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0

@fsubal fsubal temporarily deployed to preview-channel June 6, 2023 14:43 — with GitHub Actions Inactive
@fsubal fsubal temporarily deployed to preview-channel June 6, 2023 15:25 — with GitHub Actions Inactive
@fsubal fsubal requested a review from naporin0624 June 6, 2023 15:28
@toshusai
Copy link
Contributor

toshusai commented Jun 7, 2023

#164 こちらの問題も併せて解決したいです

@fsubal fsubal temporarily deployed to preview-channel June 7, 2023 05:21 — with GitHub Actions Inactive
@fsubal fsubal force-pushed the revert-286-revert-211-issue-209 branch 3 times, most recently from 740a3a6 to 8dfed98 Compare June 14, 2023 12:39
@fsubal fsubal force-pushed the revert-286-revert-211-issue-209 branch from 8dfed98 to a89f90d Compare June 14, 2023 12:42
@fsubal fsubal temporarily deployed to preview-channel June 14, 2023 12:42 — with GitHub Actions Inactive
@fsubal fsubal temporarily deployed to preview-channel June 14, 2023 12:48 — with GitHub Actions Inactive
@fsubal fsubal temporarily deployed to preview-channel June 14, 2023 12:51 — with GitHub Actions Inactive
Comment on lines 41 to 50
<p>
<InlineCode>&lt;input&gt;</InlineCode>の<InlineCode>props</InlineCode>
を継承しています。
</p>
<p>
<InlineCode>multiline</InlineCode>
の時は<InlineCode>&lt;textarea&gt;</InlineCode>の
<InlineCode>props</InlineCode>
を継承しています。
</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>
<InlineCode>&lt;input&gt;</InlineCode><InlineCode>props</InlineCode>
を継承しています。
</p>
<p>
<InlineCode>multiline</InlineCode>
の時は<InlineCode>&lt;textarea&gt;</InlineCode>の
<InlineCode>props</InlineCode>
を継承しています。
</p>
<p>
<InlineCode>&lt;textarea&gt;</InlineCode><InlineCode>props</InlineCode>
を継承しています。
</p>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

合わせてv3.0.0-guide.page.tsxに変更点も追記してほしいです。

@toshusai toshusai merged commit 2296e37 into v3.0.0 Jun 21, 2023
@fsubal fsubal deleted the revert-286-revert-211-issue-209 branch June 21, 2023 07:45
@toshusai toshusai mentioned this pull request Jun 29, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants