Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sub-module import polished #397

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

yue4u
Copy link
Contributor

@yue4u yue4u commented Oct 5, 2023

やったこと

スクリーンショット 2023-10-05 14 32 03
スクリーンショット 2023-10-05 14 35 23

TODOs in the future:

  1. We should avoid parsing/computing colors/styles at runtime as much as we can
    2. if we really need, use color-mix https://caniuse.com/?search=color-mix if available
    3. it's not easy to do currently due to applyEffect accepts any unknown effect from custom theme
    4. maybe deprecating the concept of runtime effect at all?

動作確認環境

チェックリスト

不要なチェック項目は消して構いません

  • 破壊的変更がある場合には、対象のパッケージのメジャーバージョンが上がっていることを確認した
  • 追加したコンポーネントが index.ts から再 export されている
  • README やドキュメントに影響があることを確認した

@toshusai toshusai self-requested a review January 10, 2024 04:22
@toshusai toshusai added the patch label Jan 10, 2024
Copy link
Contributor

@toshusai toshusai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR 👍 I apologize for the delay in reviewing it. It looks good to me.

@toshusai toshusai merged commit 7c604f5 into pixiv:main Jan 10, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants