[1.0] Add Humanoid helper #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyamadan
reviewed
Jun 23, 2022
| this._boneAxesMap = new Map(); | ||
|
|
||
| Object.values(humanoid.humanBones).forEach((bone) => { | ||
| if (bone) { |
There was a problem hiding this comment.
ここ、boneはfalsyになることあるんですね。
There was a problem hiding this comment.
そんなことないですね。if文外してしまいます。
There was a problem hiding this comment.
nyamadan
reviewed
Jun 23, 2022
| Array.from(this._boneAxesMap.entries()).forEach(([bone, axes]) => { | ||
| bone.node.updateWorldMatrix(true, false); | ||
|
|
||
| bone.node.matrixWorld.decompose(_v3A, _quatA, _v3B); |
There was a problem hiding this comment.
decomposeしたけど_v3aと_quatAは特に使っていない。
後で直接matrixWorldをコピーしている。
nyamadan
approved these changes
Jun 23, 2022
Add a type assertion instead The type assertion is not needed if we use later versions of TypeScript. Remove it later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
VRMHumanoidHelperwhich visualizes humanoid bones.This PR was originally done in #889 but since Humanoid Rig changes are going to be difficult I separated the humanoid helper changes into this PR.