Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pairs in a "list of pairs" dataset collection for input to pipeline #18

Closed
pjbriggs opened this issue Feb 9, 2017 · 2 comments
Closed

Comments

@pjbriggs
Copy link
Owner

pjbriggs commented Feb 9, 2017

The pipeline tool can accept a "list of pairs" dataset collection as input, but currently the names of each pair (taken from the names of the fastqs which comprise the pair) are ignored when preparing input for the pipeline.

Instead the names are taken in order from the first column of the supplied Metatable.txt file; however this procedure is not transparent and unsafe.

A preferable approach would be to use the names directly from the collection, and provide a way to easily rename the pairs e.g. by supplying a tool which could create a new collection using a file mapping pair names to new names.

@pjbriggs
Copy link
Owner Author

The relabelling tool implemented in PR #20 isn't really fit for purpose (see comments in the PR).

A vastly superior implementation is available here galaxyproject/galaxy#3603.

Galaxy code can be patched to enable the tool using e.g.

cd /PATH/TO/galaxy
wget https://github.com/galaxyproject/galaxy/pull/3603.patch
patch [--dry-run] -i 3603.patch -p 1

Also if the Galaxy instance has a config/tool_conf.xml then the new tool must be added there too:

<tool file="${model_tools_path}/relabel_from_file.xml" />

@pjbriggs
Copy link
Owner Author

Closing this issue as Galaxy now has a Relabel List Identifiers... tool (under Collection Operations) which can be used for doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant