Pull in changes needed to fix tests for -CURRENT #1

ngie-eign · 2013-04-17T20:41:05Z

This fixes some of the initial items needed in order to make the tests pass a bit more cleanly on CURRENT with UFS, in particular:

Increase the filesystem size in some of the tests so newfs doesn't fail.
Fail quickly if mdconfig/newfs fails to execute cleanly.
Check for EMLINK with open/16.t on FreeBSD, not EACCES.
Add support for detecting noexec so the test programs properly handle those scenarios as the code previously assumed that exec was always on on a filesystem. Preliminary nosuid support was added to misc.sh as well, but nosuid checks need to be backfilled in the scripts. These were needed when testing against OneFS.
Add support for detecting when pjdfstest is being run as root -- which is required when calling chflags/01.t, jail(8), and potentially other commands.
Iterate down directories for conf/pjdfstest so the installation doesn't require the tests be installed in the tests directory.
Fix the number of tests reported via ftruncate/00.t .
Allow the program to be compiled on FreeBSD 7.2; use __FreeBSD_version__ as a guide for what functionality should/shouldn't be enabled syscall wise.

Testing done:

UFS:

# uname -a
FreeBSD fbsd-vm.zonarsystems.net 11.0-CURRENT FreeBSD 11.0-CURRENT #2 5dc0f18(atf): Tue Apr  8 18:39:49 PDT 2014     root@fbsd-vm.zonarsystems.net:/usr/obj/usr/src/sys/GENERIC  i386
# mount | grep $PWD
/dev/md24 on /tmp/foobar (ufs, local, soft-updates)
# cd /tmp/foobar/; script /mnt/git/pjdfstest/typescript
Script started, output file is /mnt/git/pjdfstest/typescript
...
All tests successful.
Files=220, Tests=12216, 949 wallclock secs ( 4.31 usr  2.60 sys + 31.61 cusr 251.57 csys = 290.09 CPU)
Result: PASS

ZFS:

# uname -a
FreeBSD bayonetta.local 9.2-RELEASE-p3 FreeBSD 9.2-RELEASE-p3 #9 r+d4026d5: Sun Apr 20 01:53:29 PDT 2014     nikki@bayonetta.local:/usr/obj/usr/src/sys/BAYONETTA  amd64
# mount | grep $PWD
sac/scratch/pjdfstest on /scratch/pjdfstest (zfs, local, nfsv4acls)
# prove -rv /scratch/git/github/yaneurabeya-pjdfstest/
...
ok 269
ok 270
ok
/scratch/git/github/yaneurabeya-pjdfstest/tests/unlink/12.t ..... 
1..1
ok 1
ok
/scratch/git/github/yaneurabeya-pjdfstest/tests/unlink/13.t ..... 
1..2
ok 1
ok 2
ok
All tests successful.
Files=220, Tests=11421, 325 wallclock secs ( 2.60 usr  0.45 sys + 11.68 cusr 30.55 csys = 45.28 CPU)
Result: PASS

I haven't run the tests on OneFS recently.

1. Some testcases assume that the user has root privileges (use mdconfig -a / mount, etc). 2. Linux support exists at one degree or another. Submitted as misc/161915. Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

1. Add an all target 2. Conditionalize CC 3. Add LDLIBS/LDFLAGS Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

This is required (at least) when dealing with jails on FreeBSD Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

New versions print out messages in the format... $ echo foo | openssl md5 -hex (stdin)= d3b07384d113edec49eaa6238ad5ff00 Trim the '(stdin)= ' part Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

It really only needs to be checked once at the start of the script Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

pjd · 2013-04-17T21:11:26Z

Garrett, I had some changes that I forgot to merge from FreeBSD. I just did that, could you update your tree and generate pull request again?

Thanks!

- Recognize 'none' or '0' as no flags. - Allow to separate flags with |.

Add support for bindat(2) and connectat(2).

Add support for the chflagsat(2) syscall.

ngie-eign · 2013-04-17T23:26:44Z

Uh, I guess I can try this again..

Conflicts: Makefile

The important points to note is that __FreeBSD_version is now being used to pick out when features were added with appropriate HAS_* macros in the .c file. Sponsored-by: EMC Isilon

Sponsored-by: EMC Isilon

Conflicts: tests/misc.sh

Conflicts: Makefile

Reported-by: Casey Peel @isilon.com

Change the memory disk size to 512kB to newfs failures in select cases Also, die quickly on mount failures Sponsored-by: EMC / Isilon Submitted-by: Casey Peel @ isilon.com

This is being done to avoid sed hacks to misc.sh and make the installation a little more flexible to avoid an extra directory element (tests/) in the install.

ngie-eign · 2014-04-29T07:18:10Z

pjd@: ping?

Key HAS_CHFLAGSAT off __FreeBSD_version__

Pull in changes needed to fix tests for -CURRENT

Improves the case declaration by adding support for file types. For each specified file type, a new test case structure is created. It also automatically declare root requirement for privileged file types. This will allow future parallelization for these tests. Closes pjd#1

Garrett Cooper added 11 commits April 12, 2013 16:13

Properly call out the requirements in the documentation.

29f79d5

1. Some testcases assume that the user has root privileges (use mdconfig -a / mount, etc). 2. Linux support exists at one degree or another. Submitted as misc/161915. Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Improve the Makefile

3f12a14

1. Add an all target 2. Conditionalize CC 3. Add LDLIBS/LDFLAGS Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Fail quickly if mdconfig or newfs fails

b408624

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Shoehorn in support for checking for root

eb38c72

This is required (at least) when dealing with jails on FreeBSD Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Require root appropriately

266597c

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Fix requires_root function

999f6f8

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Update per new versions of openssl

d895979

New versions print out messages in the format... $ echo foo | openssl md5 -hex (stdin)= d3b07384d113edec49eaa6238ad5ff00 Trim the '(stdin)= ' part Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Fix the number of tests that will be executed

c1a6096

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Remove requires_root from jexpect

ae08aa0

It really only needs to be checked once at the start of the script Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Handle EMLINK on FreeBSD properly

8035e2c

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

Fix a compile-time warning when WARNS=6

8fde286

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

pjd added 5 commits April 17, 2013 16:20

Make namegeneration to work with both new and old OpenSSL.

7307021

Merge from FreeBSD r238110:

4cc79ac

- Recognize 'none' or '0' as no flags. - Allow to separate flags with |.

Style fix.

2299647

Merge from FreeBSD r247669:

af3a80b

Add support for bindat(2) and connectat(2).

Merge from FreeBSD:

e460c7e

Add support for the chflagsat(2) syscall.

ngie-eign closed this Apr 17, 2013

ngie-eign reopened this Apr 17, 2013

Garrett Cooper added 10 commits April 28, 2013 02:01

Merge remote-tracking branch 'upstream/master'

d7c15c2

Conflicts: Makefile

Make this compile on 7.2 again

2fde644

The important points to note is that __FreeBSD_version is now being used to pick out when features were added with appropriate HAS_* macros in the .c file. Sponsored-by: EMC Isilon

Refine the filesystem printing check for FreeBSD

c8e7874

Sponsored-by: EMC Isilon

Factor out determining the mountpoint into its own function

bd306e1

Do the same for the "unsupported OS" message

Add a means for determining mount options from mount -p on FreeBSD

95cfd13

and from that help determine whether or not exec/suid is possible Sponsored-by: EMC Isilon

Add a means for determining mount options from mount -p on FreeBSD

9011cc5

and from that help determine whether or not exec/suid is possible Sponsored-by: EMC Isilon

Make the noexec, nosuid, mount_options, etc functions work

a2ac773

Shove the FreeBSD bits under a FreeBSD-specific check Sponsored-by: EMC Isilon

Fix when error gets set

b830caf

Sponsored-by: EMC Isilon

Apply noexec to tests that need it so that they don't fail errantly

1e7b1eb

Sponsored-by: EMC Isilon

Merge branch 'onefs'

2208fc7

Conflicts: tests/misc.sh

Garrett Cooper and others added 4 commits April 9, 2014 15:58

Merge remote-tracking branch 'upstream/master'

f76090e

Conflicts: Makefile

Rely on autodetection I did earlier with __FreeBSD_version

08a31c4

Fix when the description gets set

fdf4e00

Reported-by: Casey Peel @isilon.com

Fix pjdfstest on 11-CURRENT with UFS

b8e1e30

Change the memory disk size to 512kB to newfs failures in select cases Also, die quickly on mount failures Sponsored-by: EMC / Isilon Submitted-by: Casey Peel @ isilon.com

ngie-eign changed the title ~~Pull in changes needed to fix tests for 10-CURRENT~~ Pull in changes needed to fix tests for -CURRENT Apr 10, 2014

ngie-eign mentioned this pull request Apr 25, 2014

open16.t fails because FreeBSD returns EMLINK, not ELOOP #3

Closed

Automatically traverse down directories to find conf/pjdfstest

eba97d8

This is being done to avoid sed hacks to misc.sh and make the installation a little more flexible to avoid an extra directory element (tests/) in the install.

Garrett Cooper added 2 commits April 29, 2014 18:57

Fix building on FreeBSD versions <10

aa5e509

Key HAS_CHFLAGSAT off __FreeBSD_version__

Ignore pjdfstest binary

18a5ad5

pjd added a commit that referenced this pull request Sep 7, 2015

Merge pull request #1 from yaneurabeya/master

5da59ab

Pull in changes needed to fix tests for -CURRENT

pjd merged commit 5da59ab into pjd:master Sep 7, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pull in changes needed to fix tests for -CURRENT #1

Pull in changes needed to fix tests for -CURRENT #1

ngie-eign commented Apr 17, 2013

pjd commented Apr 17, 2013

ngie-eign commented Apr 17, 2013

ngie-eign commented Apr 29, 2014

Pull in changes needed to fix tests for -CURRENT #1

Pull in changes needed to fix tests for -CURRENT #1

Conversation

ngie-eign commented Apr 17, 2013

pjd commented Apr 17, 2013

ngie-eign commented Apr 17, 2013

ngie-eign commented Apr 29, 2014