Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird things can happen with email addresses #11

Closed
pjf opened this issue Mar 12, 2013 · 2 comments
Closed

Weird things can happen with email addresses #11

pjf opened this issue Mar 12, 2013 · 2 comments
Labels

Comments

@pjf
Copy link
Owner

pjf commented Mar 12, 2013

Apparently one can login using an email address instead of a username. Our code is not expecting this. Either:

  1. Detect attempts to login by email address and die noisily (asking for username).
  2. Fix the code to be email address friendly.
@wizonesolutions
Copy link

Re. point 2, I think the code is username-friendly already? :P

On Tue, Mar 12, 2013 at 9:41 AM, Paul Fenwick notifications@github.comwrote:

Apparently one can login using an email address instead of a username. Our
code is not expecting this. Either:

  1. Detect attempts to login by email address and die noisily (asking
    for username).
  2. Fix the code to be username friendly.


Reply to this email directly or view it on GitHubhttps://github.com/pfenwick/idonethis-perl/issues/11
.

@pjf
Copy link
Owner Author

pjf commented Mar 12, 2013

D'oh. I meant email-address friendly. :) Fixing description now.

@pjf pjf mentioned this issue Mar 29, 2013
@pjf pjf closed this as completed in 3db4525 Dec 27, 2013
pjf added a commit that referenced this issue Dec 27, 2013
    * FEATURE: Allow optional calendar field in ~/.idonethisrc
               (Courtesy @norbu09, GH #15)

    * FEATURE: Logins with email addresses (as well as user-names)
               are now handled. (GH #11)

    * BUGFIX: More robust handling of finding calnedar links.
              We now fall-back to the 'personal' calendar if no
              other links are found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants