Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recursively check if a bucket is dirty #10

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Conversation

pjtatlow
Copy link
Owner

@pjtatlow pjtatlow commented May 1, 2021

When checking if a bucket is dirty to see if we need to rebalance, we need to check child buckets recursively to see If things are dirty.

This should fix #9!

@0xAAE
Copy link

0xAAE commented May 4, 2021

Actually it's a good job! I have tested the branch in my code and everything works well. The related issue is subject to close with resolved status

@pjtatlow
Copy link
Owner Author

pjtatlow commented May 5, 2021

Awesome, glad it's working. I seem to have a panic in some tests though, but I haven't been able to reproduce it yet. I'll eventually figure it out though, and when I do I'll merge in this change and cut a new release.

@pjtatlow pjtatlow merged commit f6a7472 into master Dec 15, 2022
@pjtatlow pjtatlow deleted the check-bucket-dirtiness branch December 15, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panicked at 'attempt to subtract with overflow'
2 participants