Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jammdb rewrite #17

Merged
merged 12 commits into from
Jan 14, 2023
Merged

jammdb rewrite #17

merged 12 commits into from
Jan 14, 2023

Conversation

pjtatlow
Copy link
Owner

Complete rewrite of the database to remove a ton of unsafe code.

Deleted the Ptr struct, and store buckets and nodes in a more idiomatic way rather than using unsafe pointers.

Stops copying the bytes written to the database, to vectors and using unsafe pointers to refer to them. Instead uses the ToBytes trait to safely accept a &[u8] as long as it outlives the transaction. You can also pass in a Vec or a bytes::Bytes and they will not be copied.

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 92.90% // Head: 94.74% // Increases project coverage by +1.83% 🎉

Coverage data is based on head (3e902fa) compared to base (c795af4).
Patch coverage: 95.16% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   92.90%   94.74%   +1.83%     
==========================================
  Files          18       21       +3     
  Lines        1790     3614    +1824     
==========================================
+ Hits         1663     3424    +1761     
- Misses        127      190      +63     
Impacted Files Coverage Δ
src/errors.rs 20.68% <0.00%> (-8.48%) ⬇️
tests/common/record.rs 86.22% <86.22%> (ø)
src/data.rs 88.23% <88.23%> (-5.19%) ⬇️
src/tx.rs 88.45% <88.45%> (ø)
src/page_node.rs 89.65% <89.65%> (ø)
src/bytes.rs 90.66% <90.66%> (ø)
tests/multiple_txs.rs 94.64% <94.11%> (+0.64%) ⬆️
src/db.rs 94.63% <95.04%> (+5.65%) ⬆️
tests/common/mod.rs 95.45% <95.45%> (-4.55%) ⬇️
src/node.rs 95.82% <95.82%> (+5.82%) ⬆️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pjtatlow pjtatlow merged commit eb03815 into master Jan 14, 2023
@pjtatlow pjtatlow deleted the jammdb-rewrite branch June 16, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant