Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning deprecation / naming change for sub module usage #49 #50

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

ohadmen
Copy link
Contributor

@ohadmen ohadmen commented Feb 5, 2022

-deprecate unused variable warning
-change post_install variable for external usage

-change post_install variable for external usage
- remove gpio_name from _remove_edge_detect
@pjueon
Copy link
Owner

pjueon commented Feb 7, 2022

Thank you for the contribution!

I checked your change and I approve it.
I removed the unused argument from _remove_edge_detect function.
Maybe I should add support for callbacks with no argument later.

@pjueon pjueon merged commit d3bc84c into pjueon:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants