Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add “Script” as a key replacement option #19

Merged
merged 1 commit into from
Mar 22, 2015
Merged

Add “Script” as a key replacement option #19

merged 1 commit into from
Mar 22, 2015

Conversation

dlh
Copy link
Contributor

@dlh dlh commented Apr 18, 2014

This branch adds Script as a key replacement option.

I was having an issue with a service I wrote and globally bound to the F13 key (System Preferences → Keyboard → Shortcuts). F13 would launch the service, but only after I clicked the app menu (which holds the Services sub-menu)—it seems others have had the same issue. Thus, PowerKey would not consistently work on my headless media-server.

Note: I did not update the etc/screenshots/remappingOptions_small.png screenshot.

@pkamb
Copy link
Owner

pkamb commented Apr 18, 2014

Beautiful, thanks! Will test this and pull it in soon.

@dlh
Copy link
Contributor Author

dlh commented Apr 20, 2014

I pushed a small change to better handle when the user presses the script-open-panel's cancel button.

@pkamb
Copy link
Owner

pkamb commented Apr 21, 2014

@dlh did you push that change? I only see the one commit d759664

@dlh
Copy link
Contributor Author

dlh commented Apr 21, 2014

I rebased and force-pushed.

@pkamb pkamb mentioned this pull request Apr 22, 2014
@pkamb pkamb added this to the v1.3 milestone Apr 22, 2014
@pkamb
Copy link
Owner

pkamb commented Apr 23, 2014

Thanks, I've pushed this to the script branch rather than merge the PR into master.

I think we should support AppleScript files before releasing this.

I like the minimal UI of selecting a file by simply selecting the "script" key replacement, but it's confusing when you can't Open a file (such as an AppleScript file) from the panel. Open button seems to not work. We'll need to disable to Open button, grey out invalid files, present some kind of error text, etc.

Thanks for your work on this! Feel free to continue working on it or I will polish it up for the next release.

@pkamb pkamb merged commit d759664 into pkamb:master Mar 22, 2015
@pkamb
Copy link
Owner

pkamb commented Mar 22, 2015

Thank you for your work on this @dlh! I've (finally) released Script and AppleScript functionality in v1.3:

https://github.com/pkamb/PowerKey/releases/tag/v1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants