Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for touchid single/triple clicks #54

Closed
wants to merge 3 commits into from

Conversation

jdlien
Copy link
Contributor

@jdlien jdlien commented Apr 6, 2017

On the MacBook Pros with Touchbar, touchID has subtype 16 for single clicks (NX_SUBTYPE_MENU) or 17 for triple clicks (NX_SUBTYPE_ACCESSIBILITY).

I have added support for those, however double clicks do nothing and there is a significant delay between keypresses on the TouchID button.

@pkamb
Copy link
Owner

pkamb commented Apr 6, 2017

This is great! Thanks for investigating. I'd like to play around with this on a Macbook Pro with Touch Bar before merging. I'll try to find a test device to use soon.

@JoeDuncko
Copy link

Any word on if this has been tested or is about to be merged? Long time PowerKey user, I've bought it on Gum Road, just bought a Mac with the touch bar.

I can test if you need me to to get this going!

@jdlien
Copy link
Contributor Author

jdlien commented Jul 24, 2017 via email

@JoeDuncko
Copy link

@jdlien sent me his build of PoweKey last night and I can verify it does the job. Thanks again for sending me that @jdlien !

@hkgusabe
Copy link

hkgusabe commented Jul 30, 2017 via email

@pkamb
Copy link
Owner

pkamb commented Oct 1, 2017

I created a new PR for this feature here: #60. Will close this PR in favor of the new one (which contains all of the same commits).

@pkamb pkamb closed this Oct 1, 2017
@pkamb
Copy link
Owner

pkamb commented Oct 3, 2017

Touch Bar support has been released in version 1.6!
https://github.com/pkamb/PowerKey/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants