-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for touchid single/triple clicks #54
Conversation
This is great! Thanks for investigating. I'd like to play around with this on a Macbook Pro with Touch Bar before merging. I'll try to find a test device to use soon. |
Any word on if this has been tested or is about to be merged? Long time PowerKey user, I've bought it on Gum Road, just bought a Mac with the touch bar. I can test if you need me to to get this going! |
I have been using it for months and it has been working just fine. I haven’t heard from Peter about this but I was wondering if he was about to integrate this into the production version any time soon.
JD Lien
Mobile: 780-702-3114
…On Jul 23, 2017, 21:52 -0600, Joe Duncko ***@***.***>, wrote:
Any word on if this has been tested or is about to be merged? Long time PowerKey user, I've bought it on Gum Road, just bought a Mac with the touch bar.
I can test if you need me to to get this going!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Hi Peter.
I hope you get this email. I have been getting redirected a lot from email
links to other than what I expected to get linked to. How do I correct this
problem. Getting redirected to different sites. When I go back and try
again to click then again I get redirected to a newer site not even the
same one I just got directed too. Is the answer to just try to stay away
from junk mail.
Love You.
…On Wed, Apr 5, 2017 at 6:24 PM, JD Lien ***@***.***> wrote:
On the MacBook Pros with Touchbar, touchID has subtype 16 for single
clicks (NX_SUBTYPE_MENU) or 17 for triple clicks (NX_SUBTYPE_ACCESSIBILITY).
I have added support for those, however double clicks do nothing and there
is a significant delay between keypresses on the TouchID button.
------------------------------
You can view, comment on, or merge this pull request online at:
#54
Commit Summary
- Added support for touchid single/triple clicks
File Changes
- *M* PowerKey/PKPowerKeyEventListener.m
<https://github.com/pkamb/PowerKey/pull/54/files#diff-0> (16)
Patch Links:
- https://github.com/pkamb/PowerKey/pull/54.patch
- https://github.com/pkamb/PowerKey/pull/54.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#54>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AT6jvt5UG_4bFdTuE41Ql_xrdwLNykk5ks5rtD7FgaJpZM4M1Abc>
.
|
I created a new PR for this feature here: #60. Will close this PR in favor of the new one (which contains all of the same commits). |
Touch Bar support has been released in version 1.6! |
On the MacBook Pros with Touchbar, touchID has subtype 16 for single clicks (NX_SUBTYPE_MENU) or 17 for triple clicks (NX_SUBTYPE_ACCESSIBILITY).
I have added support for those, however double clicks do nothing and there is a significant delay between keypresses on the TouchID button.