Adrian witness #23
Merged
Adrian witness #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 1, 2014 08:14
These are needed for witness.
STACK is required for witness.
The witness code unlocks giant during its init, which actually pisses off witness if it's not held!
* Make witness not panic the process - it's easily changed by just redefining WITNESS_PANIC * Fix up a case where the code assumes witness would panic - it should just fall through. * Disable the code to handle spinlock checks - the per-cpu and critical section stuff on libuinet isn't 100% the same (and I don't think it can or should be.)
…tines. It's (mostly) not relevant here.
* Extend most of the lock calls to track file:line up to the UHI routines.. * .. which can then optionally log as appropriate. * Optionally support using libunwind to unwind a stack when needed - this is used by witness to track the stack state when a witness assertion is hit. * Add witness macro calls to the uinet implementation of locks * Add a (blank, debug printf) copy of spinlocks - witness at least checks that the lock object for spinlocks is real.
pkelsey
added a commit
that referenced
this pull request
Sep 1, 2014
Witness support from Adrian. There are a few tweaks to this coming soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.