Fix for issue #68: Avoid leaking FD, in case of error #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
davecheney
requested changes
Dec 17, 2021
term_open_posix.go
Outdated
| @@ -22,13 +22,21 @@ func Open(name string, options ...func(*Term) error) (*Term, error) { | |||
|
|
|||
| orig, err := termios.Tcgetattr(uintptr(fd)) | |||
| if err != nil { | |||
| _ = unix.Close(fd) | |||
There was a problem hiding this comment.
no need to assign the value to _, just write unix.Close(fd)
There was a problem hiding this comment.
Fixed on both files and squashed.
Almost the same fix than a former fix in termios/pty.go When xx.Open() succeeds, ensure FD is closed, when an error is detected with other treatments. Fix applied in term_open_posix.go and term_solaris.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost the same fix than a former fix in termios/pty.go
When xx.Open() succeeds, ensure FD is closed, when an error
is detected with other treatments.
Fix applied in term_open_posix.go and term_solaris.go