Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape spaces in stubs for uninstallation #1000

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Apr 27, 2024

I noticed this problem when trying to uninstall Python:

image

Obviously, the source problem is something else that should be fixed. But nevertheless, the stubs should be protected. There may exist some real program name with spaces as well, for example.

Before

image

After

image

@felipecrs felipecrs marked this pull request as ready for review April 27, 2024 15:50
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 27, 2024
@felipecrs felipecrs changed the title Escape spaces in stubs when uninstalling Escape spaces in stubs for uninstallation Apr 27, 2024
@felipecrs
Copy link
Contributor Author

The -f prevents errors like these:

$ pkgx uninstall jfrog
rm: cannot remove 'jf': No such file or directory

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 6, 2024
@mxcl mxcl merged commit 01ca8db into pkgxdev:main Sep 6, 2024
5 checks passed
@felipecrs felipecrs deleted the fix-uninstall-spaces branch September 6, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants