Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prepare for Deno 2.0 migrations (use no deprecated APIs) #974

Closed
wants to merge 7 commits into from

Conversation

rustdevbtw
Copy link
Contributor

Prepares for migration to Deno 2.0

Changes

Deno.isatty(*.rid) -> Deno.*.isTerminal()
clicolor(*.rid) -> clicolor(*)

I also removed the isatty test and removed isatty fom $_internals.
I also replaced --unstable flag with --unstable-ffi and --unstable-fs.

Signed-off-by: Rajdeep Malakar <rajdeepm.dev@gmail.com>
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 13, 2024
@rustdevbtw rustdevbtw marked this pull request as draft February 13, 2024 18:19
@rustdevbtw
Copy link
Contributor Author

It'll require us to use latest Deno (>=1.40). I'm not sure whether this migration is worth changing minimum required Deno version. @mxcl what do you think?

@rustdevbtw
Copy link
Contributor Author

It's a duplicate of #953 ig

@rustdevbtw rustdevbtw closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant