Programatically produce cosmetic formes #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a `getBL` function because people recommended not writing the same code twice
scheibo
reviewed
Sep 18, 2024
This reverts commit 3bc0166.
shrianshChari
changed the title
|
The reports tests have been reenabled. Per discussion on Discord adding a |
Uses a `getBL` function because people recommended not writing the same code twice
|
Me when I butcher a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires tests to be re-enabled (#3) before we can test these changes
The updates to cosmetic formes does not use the
species.cosmeticFormesattribute because then it would produce output that is inconsistent with Antar's original code. Instead, I have used the Pokemon's typing and base stats to identify formes that can be skipped. The only exception is Basculin, which has a single different ability between its red-striped and blue-striped forme (Reckless and Rock Head, respectively). However, Antar included it in his list, and it's for two abilities that don't even get used on Basculin, so it's fine.