Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tgyuu/#130 #132

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Feature/tgyuu/#130 #132

merged 6 commits into from
Feb 22, 2024

Conversation

tgyuuAn
Copy link
Member

@tgyuuAn tgyuuAn commented Feb 18, 2024

1. πŸ“„ κ΄€λ ¨λœ 이슈 및 μ†Œκ°œ

closed #130

2. πŸ”₯ λ³€κ²½λœ 점

-ν”„λ‘œν•„ νŽ˜μ΄μ§€μ—μ„œλ„ λ‚΄κ°€ μž‘μ„±ν•œ 섀문을 확인할 수 μžˆλ„λ‘ λ³€κ²½

3. βœ… κΌ­ ν™•μΈν•΄μ€¬μœΌλ©΄ ν•˜λŠ” λΆ€λΆ„

4. πŸ“Έ μŠ€ν¬λ¦°μƒ·(선택)

5. πŸ’‘μ•Œκ²Œλœ ν˜Ήμ€ κΆκΈˆν•œ 사항듀

@tgyuuAn
[FEATURE] #130 : ν”„λ‘œν•„ ν™”λ©΄μ—μ„œ μ„€λ¬Έ 클릭 μ‹œ λ‚΄κ°€ μž‘μ„±ν•œ 섀문을 λ³Ό 수 μžˆλ„λ‘ λ³€κ²½
beff37b
@tgyuuAn
[FEATURE] #130 : ν”„λ‘œν•„ -> μ„€λ¬Έ 응닡 νŽ˜μ΄μ§€μ‹œ λ’€λ‘œ κ°€λ©΄ ν”„λ‘œν•„λ‘œ 가도둝 λ³€κ²½
51e4f00
@tgyuuAn
[FEATURE] #130 : survey Detail νŽ˜μ΄μ§€ λ’€λ‘œ κ°€κΈ° ν˜Ήμ€ μ™„λ£Œ λ²„νŠΌ λˆ„λ₯Ό μ‹œ ν”„λ‘œν•„ ν˜Ήμ€ survey …
8e2dcc3 
…Check νŽ˜μ΄μ§€λ‘œ λŒμ•„κ°€λ„λ‘ λ³€κ²½
@tgyuuAn
[FEATURE] #130 : survey Detail νŽ˜μ΄μ§€ λ‘œλ”© Lottie μΆ”κ°€
3639ef4
@tgyuuAn
[FEATURE] #130 : survey Detail νŽ˜μ΄μ§€ μ™„λ£Œ λ²„νŠΌ ν•˜λ‹¨ κ³ μ •
034f0b0
@tgyuuAn
[FEATURE] #130 : μ‚¬μš©μž 응닡 색상 λ…Έλž€μƒ‰μœΌλ‘œ ν•˜μ΄λΌμ΄νŒ… 적용
13bf640
@tgyuuAn tgyuuAn added 🌱기λŠ₯🌱 μƒˆλ‘œμš΄ κΈ°λŠ₯ 두두λ‘₯μž₯! πŸŽ¨μœ μ•„μ΄πŸŽ¨ ν”Όκ·Έλ§ˆ, μ—‘μ„Έλ©œ, 컴포즈 μœ μ•„μ΄/μœ μ—‘μŠ€ μž‘μ—… πŸ§©νƒœκ·œπŸ§© ENFP μ•ˆνƒœκ·œ 24μ„Έ πŸ”₯리뷰 κΈ°λ‹€λ¦¬λŠ” 쀑πŸ”₯ PR을 올리고 μ½”λ“œλ¦¬λ·°λ₯Ό 기닀리고 μžˆλŠ” μƒνƒœμž…λ‹ˆλ‹€. βœ…μŠ€νƒ€μΌ βœ… μ½”λ“œ ν¬λ§·νŒ… μˆ˜μ •, νƒ€μž…μ΄λ‚˜ ν•¨μˆ˜λͺ… μˆ˜μ • labels Feb 18, 2024
@tgyuuAn tgyuuAn self-assigned this Feb 18, 2024
@tgyuuAn tgyuuAn removed the βœ…μŠ€νƒ€μΌ βœ… μ½”λ“œ ν¬λ§·νŒ… μˆ˜μ •, νƒ€μž…μ΄λ‚˜ ν•¨μˆ˜λͺ… μˆ˜μ • label Feb 18, 2024
@Munbin-Lee
Copy link

κΊΌμ–΄μ–΅

jeongjaino
jeongjaino reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

νƒœκ·œμƒ μˆ˜κ³ ν•˜μ…¨μ–΄μš” πŸ‘

μ½”λ“œλž‘ μ»€λ°‹λ‚΄μ—­μ΄λž‘ μ­‰ ν•œλ²ˆ μ½μ–΄λ΄€λŠ”λ°, ν•˜λ‚˜μ˜ κΈ°λŠ₯에 λŒ€ν•œ 것듀이라 μ½”λ©˜νŠΈλŠ” λ”°λ‘œ μ•ˆλ‚¨κ²Όμ–΄μš”

μ½”μ½” κΈ°λ‹€λ¦΄κ²Œμš” γ…Žγ…Ž

app/src/main/java/com/wap/wapp/navigation/WappNavHost.kt
Comment on lines +116 to +122
navigateToSurveyDetail = { surveyId ->
navController.navigateToSurveyDetail(
surveyId = surveyId,
backStack = SurveyDetailBackStack.PROFILE,
navOptions = navOptions { popUpTo(profileNavigationRoute) },
)
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

νƒœκ·œμƒ Compose Navigationμ—μ„œ μ›λž˜ λ°±μŠ€νƒ 관리λ₯Ό 인자둜 μ „λ‹¬ν•΄μ„œ κ΅¬ν˜„ν•΄μ•Ό ν•˜λ‚˜μš”?

κΈ°μ‘΄ Xmlμ—μ„œλŠ” popBackStack()μ΄λΌλŠ” λ©”μ†Œλ“œκ°€ μžˆμ–΄μ„œ, 이전 ν”„λ‘œμ νŠΈμ—μ„œ ν•΄λ‹Ή λ©”μ†Œλ“œλ₯Ό μ‚¬μš©ν–ˆμ—ˆμ–΄μš”

μ•„λ§ˆ μ„€λ¬Έ μ‘λ‹΅μ˜ 경우 말고도 λ°±μŠ€νƒκ΄€λ¦¬λ₯Ό ν•΄μ€˜μ•Όν•˜λŠ” 상황이 λ°˜λ“œμ‹œ μ°Ύμ•„μ˜¬ν…λ°,
그럴 λ•Œλ§ˆλ‹€ 이전 컴포저블을 인자둜 μ „λ‹¬ν•˜κ³  -> ν˜„μž¬ μ»΄ν¬μ €λΈ”μ—μ„œ λ°±μŠ€νƒμ„ μ €μž₯ν•˜κ³  -> 이전 λ²„νŠΌμ„ λˆ„λ₯Όλ–„ λ°±μŠ€νƒμ„ κΊΌλ‚΄μ„œ λ‹€μŒ μ „ν™˜ 인자둜 λ„˜κ²¨μ£ΌλŠ”κ²Œ 번거둜운 과정이 될 μˆ˜λ„ μžˆμ„ 것 κ°™μ•„μ„œμš” 😭

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeongjaino

ν—‰ μƒκ°ν•΄λ³΄λ‹ˆ κ·ΈλŸ¬λ„€μš”.

μ°Ύμ•„λ³΄λ‹ˆ μ•„λž˜ 처럼 popBackStack이 있긴 ν•˜λ„€μš”.

image

근데 μ–΄μ§œν”Ό main NavHostμ—μ„œ λžŒλ‹€ νŒŒλΌλ―Έν„°λ‘œ ν•˜λ‚˜ ν•˜λ‚˜ μ”© λ‹€ λ„£μ–΄μ€˜μ•Ό ν•΄μ„œ

κΈ°λŠ₯μ΄λ‚˜ κ΅¬ν˜„ν•˜λŠ” λ°μ—λŠ” λΉ„μŠ·ν•  것 κ°™μ•„μš”.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전 Xmlμ—μ„œλŠ” λ”°λ‘œ 인자 없이 λ°”λ‘œ κ°€μž₯ μœ„μ—μžˆλŠ” μŠ€νƒ λ½‘μ•„μ€¬λŠ”λ°

ComposeλŠ” λ”°λ‘œ 라우트λ₯Ό λ„˜κ²¨μ•Ό λ˜λ„€μš”

그럼 κ²°κ΅­ 같은 λ‘œμ§μ΄κ² λ„€μš” μ’‹μŠ΅λ‹ˆλ‹€

@jeongjaino jeongjaino added πŸŒŸλ¨Έμ§€ ν•΄μ£Όμ„Έμš”πŸŒŸ μ½”λ“œ 리뷰가 μ™„λ£Œλœ λ’€ PR을 μ˜¬λ¦°μ‚¬λžŒμ΄ Mergeλ₯Ό ν•˜λ©΄ λ˜λŠ” λ‹¨κ³„μž…λ‹ˆλ‹€. and removed πŸ”₯리뷰 κΈ°λ‹€λ¦¬λŠ” 쀑πŸ”₯ PR을 올리고 μ½”λ“œλ¦¬λ·°λ₯Ό 기닀리고 μžˆλŠ” μƒνƒœμž…λ‹ˆλ‹€. labels Feb 22, 2024
@tgyuuAn tgyuuAn merged commit 6ca013b into develop Feb 22, 2024
1 check passed
@tgyuuAn tgyuuAn deleted the feature/tgyuu/#130 branch March 8, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongjaino jeongjaino jeongjaino approved these changes

Assignees

@tgyuuAn tgyuuAn

Labels
πŸŒŸλ¨Έμ§€ ν•΄μ£Όμ„Έμš”πŸŒŸ μ½”λ“œ 리뷰가 μ™„λ£Œλœ λ’€ PR을 μ˜¬λ¦°μ‚¬λžŒμ΄ Mergeλ₯Ό ν•˜λ©΄ λ˜λŠ” λ‹¨κ³„μž…λ‹ˆλ‹€. 🌱기λŠ₯🌱 μƒˆλ‘œμš΄ κΈ°λŠ₯ 두두λ‘₯μž₯! πŸŽ¨μœ μ•„μ΄πŸŽ¨ ν”Όκ·Έλ§ˆ, μ—‘μ„Έλ©œ, 컴포즈 μœ μ•„μ΄/μœ μ—‘μŠ€ μž‘μ—… πŸ§©νƒœκ·œπŸ§© ENFP μ•ˆνƒœκ·œ 24μ„Έ
Projects
None yet
Milestone
No milestone
3 participants
@tgyuuAn @Munbin-Lee @jeongjaino