Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glyphicons not loading properly #118

Closed
NateWr opened this issue May 1, 2019 · 1 comment
Closed

Glyphicons not loading properly #118

NateWr opened this issue May 1, 2019 · 1 comment

Comments

@NateWr
Copy link
Contributor

NateWr commented May 1, 2019

In 3.1.2 the glyphicons are not loading properly. Reported at https://forum.pkp.sfu.ca/t/missing-glyphicons-in-ojs-v3-1-2/52971.

This is happening because the relative URL is not being handled well in the LESS files. This was identified and fixed in https://github.com/NateWr/bootstrap3/issues/13, but that fix was overwritten when we updated the bootstrap library.
NateWr added a commit that referenced this issue May 1, 2019
@NateWr
Fix #118. Glyphicons URL incorrect
a05412a
@NateWr
Copy link
Contributor Author

NateWr commented May 1, 2019

This was addressed by overriding the @icon-font-path variable in the theme plugin, rather than in the bootstrap less files, so that future updates to bootstrap don't cause the issue to reappear.

@NateWr NateWr closed this as completed May 1, 2019
NateWr added a commit that referenced this issue May 1, 2019
@NateWr
Fix #118. Glyphicons URL incorrect
dda0a31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NateWr