Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double encoding on citations #118

Closed
paulo-graca opened this issue Dec 18, 2023 · 1 comment
Closed

Double encoding on citations #118

paulo-graca opened this issue Dec 18, 2023 · 1 comment
Assignees

Comments

@paulo-graca
Copy link

paulo-graca commented Dec 18, 2023

I think this issue we have is related with this one: #95

Currently we have a journal which names "Cinema & Território" and, in the citation, the name appears encoded like:
Baía Reis, A., Mendes, G., Rebanda Coelho, I., & Norton Dias, T. (2023). Editorial | A Direção da C&T. Cinema &Amp; Território, (8), 7.[ https://doi.org/10.34640/c.t8uma2023editorial](https://doi.org/10.34640/c.t8uma2023editorial)
I've found if I remove the htmlspecialchars function at line 320: CitationStyleLanguagePlugin.inc.php (https://github.com/pkp/citationStyleLanguage/blob/3_2_1-2/CitationStyleLanguagePlugin.inc.php#L320):

$citationData->{'container-title'} = htmlspecialchars($context->getLocalizedName());

the name appear correctly with one single encoding. I'm guessing that, besides this one, a second encoding occurs at the template level. So my thoughts go to have only one, but which one?

PRs:
stable-3_4_0:

main:

@bozana
Copy link
Collaborator

bozana commented Jun 27, 2024

@jonasraoni, may I ask you again to review the PR above?
The PR also solves #95.
Thanks a lot!

bozana added a commit to bozana/citationStyleLanguage that referenced this issue Jun 28, 2024
bozana added a commit to bozana/citationStyleLanguage that referenced this issue Jun 28, 2024
bozana added a commit to bozana/ojs that referenced this issue Jul 12, 2024
bozana added a commit to bozana/omp that referenced this issue Jul 12, 2024
bozana added a commit to bozana/ops that referenced this issue Jul 12, 2024
bozana added a commit that referenced this issue Jul 12, 2024
#118 remove double encoding in citations
bozana added a commit to pkp/ojs that referenced this issue Jul 12, 2024
bozana added a commit to pkp/ops that referenced this issue Jul 12, 2024
bozana added a commit to pkp/omp that referenced this issue Jul 12, 2024
bozana added a commit to bozana/citationStyleLanguage that referenced this issue Jul 12, 2024
bozana added a commit that referenced this issue Jul 12, 2024
#118 remove double encoding in citations
@bozana bozana closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants