pkp/citationStyleLanguage#118 remove double encoding in citations #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasraoni
reviewed
Jun 27, 2024
jonasraoni
reviewed
Jun 27, 2024
jonasraoni
reviewed
Jun 27, 2024
jonasraoni
reviewed
Jun 27, 2024
jonasraoni
requested changes
Jun 27, 2024
There was a problem hiding this comment.
Hi @bozana, I've tested locally and I saw the underlying library does escape data, so we really don't need to do it on our side.
I've just left a note to fix a side-bug instead of unescaping data that should be already in a text format.
|
Hi @jonasraoni, I added the PRs for publication title in text format here: pkp/pkp-lib#10135 and adapted the changes here accordingly. |
bozana
commented
Jun 28, 2024
jonasraoni
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s. #118
and #95
This issue solves the problem with double HTML encodings in citations:
For settings that we store with HTML encodings (like publication title and abstract) we need to use
htmlspecialchars_decode, because the CSL library that we use also encodes the HTML characters.I have only removed the HTML encoding from settings where needed (realized through testing).
Strangely for the other settings, like for example 'pages', it does not matter if we use
htmlspecialcharsor not -- the result is always the same :-O -- so I will leave them as they are for now.