Change JATS document creation to a DOM based model #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ipula and @withanage, this PR replaces #26.
It also adds...
->parentNode
; placement of attributes first; etc)htmlspecialchars
/ escapingmeta-value
should not be nested inmeta-name
$submission->getLocale()
should never be null$ccBadge
misplaced$ccBadge
misplacedappendChild
applied to wrong element; sections data not included in DOMkwd
should not havexml:lang
attributeSome of these are trickier to catch in review than they are while coding! It pays to work on this kind of code progressively -- modify, test, rinse and repeat, with data in your installation that exercises each piece of code you touch. Be careful with copy/paste; I think a number of weird typos came in that way.