Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JATS document creation to a DOM based model #29

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Conversation

asmecher
Copy link
Member

@asmecher asmecher commented Aug 3, 2023

@ipula and @withanage, this PR replaces #26.

It also adds...

Some of these are trickier to catch in review than they are while coding! It pays to work on this kind of code progressively -- modify, test, rinse and repeat, with data in your installation that exercises each piece of code you touch. Be careful with copy/paste; I think a number of weird typos came in that way.

@withanage
Copy link
Member

Thanks @asmecher for review!

@asmecher
Copy link
Member Author

asmecher commented Aug 4, 2023

Sorry 😨 I forgot to add! @ipula and @withanage, thanks for this, it's always bothered me that we've been building XML with string concatenation. It's finicky work and I really appreciate your willingness to rearrange it painfully based on review feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants