Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookie consent option for GDPR compliance #2106

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ajnyga
Copy link
Contributor

@ajnyga ajnyga commented Aug 25, 2018

@NateWr

Issue: pkp/pkp-lib#3624

third time the charm? Closed #2036

@ajnyga
Copy link
Contributor Author

ajnyga commented Aug 25, 2018

so it is failing almost in the same place here: https://github.com/pkp/pkp-lib/blob/master/tests/WebTestCase.inc.php#L129

The earlier versions failed on row 127. The commits are basically identical so no idea why it fails on that row now. I can not even see how the changes would affect the login?

The only thing it does concerning the login is that it adds a cookie consent (or actually privacy policy consent) box in the login form and userName is assigned to the login form only if a session exists. BUT this all happens only if the new session_limit setting is On in config.inc.php and I can not see how this would be the case in the tests?

@ajnyga
Copy link
Contributor Author

ajnyga commented Aug 27, 2018

@NateWr if you want to test this here are the branches:
OJS: #2106
PKP-LIB: pkp/pkp-lib#4015

I do not understand the test failure

Base automatically changed from master to main February 18, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant